Allow material design icons in AppSidebarTab #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
3. to review
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/1859/tabs-md-icon
branch
from
cd649d1
to
8f5b728
Compare
raimund-schluessler
requested review from
skjnldsv,
juliushaertl,
marcoambrosini and
PVince81
skjnldsv
reviewed
May 8, 2021
raimund-schluessler
force-pushed
the
fix/1859/tabs-md-icon
branch
from
fdcef2c
to
abb7bab
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
skjnldsv
approved these changes
May 8, 2021
juliushaertl
approved these changes
May 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements material design icons in the AppSidebarTabs header. The icon is not gray anymore when focused, which I think makes sense, as the text is black as well.
Before
After (sharing icon is provided by string):
Closes #1859.