Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user bubble when username contains a space #1948

Merged
merged 1 commit into from
May 12, 2021

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 11, 2021

The user bubble is broken when there is a space in the username.

This was due to the parsed value being sanitized before applying regexp on it.

I simply changed the regexp to match " instead of ".

This should fix: nextcloud/server#26861

Before After
Screenshot from 2021-05-11 18-44-02 Screenshot from 2021-05-11 18-45-17

@artonge artonge marked this pull request as ready for review May 11, 2021 16:47
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the fix/userBubbleForUserNameWithSapce branch from ad17f93 to 407f7bd Compare May 11, 2021 16:47
@artonge artonge requested a review from skjnldsv May 11, 2021 16:47
@ChristophWurst ChristophWurst merged commit 2a027af into master May 12, 2021
@ChristophWurst ChristophWurst deleted the fix/userBubbleForUserNameWithSapce branch May 12, 2021 08:27
@ChristophWurst
Copy link
Contributor

backport?

@skjnldsv skjnldsv mentioned this pull request Jun 4, 2021
@elhananjair
Copy link

Hello there is this issue(#26861 fixed yet? because am still facing this issue in NC 21.0.4 Version.

@artonge
Copy link
Contributor Author

artonge commented Aug 31, 2021

@elhananjair NC 21.0.4 uses nextcloud/vue@v3.2.0. This fix has only made it to nextcloud/vue@v4.0.0 which will be use in NC 23

@elhananjair
Copy link

@elhananjair NC 21.0.4 uses nextcloud/vue@v3.2.0. This fix has only made it to nextcloud/vue@v4.0.0 which will be use in NC 23

ow okay I will wait for it, thanks.

@elhananjair
Copy link

hey @artonge am really sorry to bring this thing again, I was just curious that this issue is not appearing in some nextcloud applications, such as deck, So does this mean some apps in nextcloud uses different versions of vue or built with different mechanism? Thanks

@artonge
Copy link
Contributor Author

artonge commented Nov 15, 2021

hey @artonge am really sorry to bring this thing again, I was just curious that this issue is not appearing in some nextcloud applications, such as deck, So does this mean some apps in nextcloud uses different versions of vue or built with different mechanism? Thanks

Yes, not all applications use this Vue component.

@elhananjair
Copy link

@artonge I don't think the issue has been fixed in NC 23. I am trying here on Talk and Files app and its the same as before

@artonge
Copy link
Contributor Author

artonge commented Dec 2, 2021

@artonge I don't think the issue has been fixed in NC 23. I am trying here on Talk and Files app and its the same as before

Can you clear your cache and check again? Can you open another issue if the problem still persist?

@elhananjair
Copy link

@artonge I don't think the issue has been fixed in NC 23. I am trying here on Talk and Files app and its the same as before

Can you clear your cache and check again? Can you open another issue if the problem still persist?

I have installed clean NC 23 and didn't upgrade from previous versions. So I don't think clearing cache or something like that won't help I guess. As you said let me open this issue again.

@nextcloud-libraries nextcloud-libraries locked as too heated and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username not showing properly on comments if username contains quotes (")
4 participants