Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally make the DatetimePicker timezone-aware #2100

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Optionally make the DatetimePicker timezone-aware #2100

merged 1 commit into from
Jul 16, 2021

Conversation

ChristophWurst
Copy link
Contributor

@ChristophWurst ChristophWurst commented Jul 9, 2021 •
edited

@ChristophWurst ChristophWurst added enhancement New feature or request 2. developing Work in progress labels Jul 9, 2021
@ChristophWurst ChristophWurst self-assigned this Jul 9, 2021
@ChristophWurst ChristophWurst force-pushed the enhancement/timezone-aware-datetime-picker branch from 47082b1 to 440dfa4 Compare July 12, 2021 09:40
@ChristophWurst ChristophWurst marked this pull request as ready for review July 15, 2021 14:48
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 15, 2021
julien-nc
julien-nc approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works like a charm.

It would be nice to make the timezone value more visible, like show the popover on hover. Anyway it's still possible to display the timezone in the formatted date.

@ChristophWurst
Optionally make the DatetimePicker timezone-aware
dbe77db 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the enhancement/timezone-aware-datetime-picker branch from 0dc9458 to dbe77db Compare July 16, 2021 09:38
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 16, 2021
@ChristophWurst ChristophWurst merged commit 5a9251b into master Jul 16, 2021
@ChristophWurst ChristophWurst deleted the enhancement/timezone-aware-datetime-picker branch July 16, 2021 09:58
@ChristophWurst ChristophWurst mentioned this pull request Aug 11, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@Pytal Pytal Pytal approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@GretaD GretaD Awaiting requested review from GretaD

@artonge artonge Awaiting requested review from artonge

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add timezone selection to the date picker
3 participants
@ChristophWurst @julien-nc @Pytal