Fix dragging onto hidden crumbs #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
bug
raimund-schluessler
requested review from
ChristophWurst,
skjnldsv,
violoncelloCH,
marcoambrosini and
nimishavijay
skjnldsv
approved these changes
Dec 21, 2021
Signed-off-by: Raimund Schl眉脽ler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/noid/drag-hidden-crumbs
branch
from
b5ea198
to
0923fa7
Compare
quentinguidee
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes dragging stuff onto crumbs that are hidden. Before the menu would immediately close after leaving the three-dots-menu, since the dropdown was attached to body, thus triggering the dragLeave handler when hovering over the dropdown.
I wanted to show a screencast, but peek doesn't work with Wayland anymore, so you gotta trust me with this one 馃槈 馃檲