Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement showing global crumb actions #2444

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Jan 6, 2022

In order to show an Actions or Buttoncomponent (or actually anything else you put into the slot) directly adjacent to the right of the last crumb, the element needs to be a child of the breadcrumbs container. So I added a slot and take the elements width into account when hiding the overflowing crumbs.

This is how it looks now with a button:
crumb
And an Actions component:
crumb1

This is the last step (maybe 馃檪) in order to make it look like @nimishavijay mockup:
mockup

@raimund-schluessler raimund-schluessler added this to the 5.0.0 milestone Jan 6, 2022
@raimund-schluessler raimund-schluessler added 2. developing Work in progress feature: breadcrumbs Related to the breadcrumbs components labels Jan 6, 2022
Signed-off-by: Raimund Schl眉脽ler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews enhancement New feature or request and removed 2. developing Work in progress labels Jan 6, 2022
@raimund-schluessler raimund-schluessler linked an issue Jan 6, 2022 that may be closed by this pull request
@raimund-schluessler raimund-schluessler marked this pull request as ready for review January 6, 2022 20:25
@raimund-schluessler raimund-schluessler self-assigned this Jan 6, 2022
Copy link

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

@skjnldsv skjnldsv merged commit ba2c60d into master Jan 10, 2022
@skjnldsv skjnldsv deleted the fix/noid/crumb-actions branch January 10, 2022 08:39
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @raimund-schluessler! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: breadcrumbs Related to the breadcrumbs components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the breadcrumbs component
5 participants