Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppNavigationItem.vue: updating of this.$slots #2483

Merged
merged 1 commit into from
Feb 9, 2022
Merged

AppNavigationItem.vue: updating of this.$slots #2483

merged 1 commit into from
Feb 9, 2022

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Feb 9, 2022 •
edited

fixes nextcloud/mail#5987

this.$slots will be updated in created() and beforeUpdate() lifecycle-hooks

@JuliaKirschenheuter
AppNavigationItem.vue was changed
f1645b9 
this.$slots will be updated in created() and beforeUpdate() lifecycle-hooks

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Feb 9, 2022
Closed
ChristophWurst
ChristophWurst approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.$slots is not reactive, hence we need to use the lifecycle hooks

👍

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component labels Feb 9, 2022
@ChristophWurst ChristophWurst modified the milestones: 4.2.0, 5.0.0 Feb 9, 2022
st3iny
st3iny approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent :shipit:

@st3iny
Copy link
Contributor

st3iny commented Feb 9, 2022

/backport to stable4

@st3iny st3iny merged commit cd0a9e3 into master Feb 9, 2022
@st3iny st3iny deleted the fix/5987-create_submailbox_in_submailboxes branch February 9, 2022 13:02
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 9, 2022
Merged
@ChristophWurst ChristophWurst mentioned this pull request Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Not possible to create submailbox in submailboxes
3 participants
@JuliaKirschenheuter @st3iny @ChristophWurst