Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shrinking of last breadcrumb for narrow width #2492

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Feb 11, 2022

After the major changes to the breadcrumb bar in #2411 and #2444 the last breadcrumb does not shrink anymore on small screens. This PR fixes it.

Before After
Without Actions before_without after_without
With Actions before_with after_with

@raimund-schluessler raimund-schluessler added bug Something isn't working feature: breadcrumbs Related to the breadcrumbs components labels Feb 11, 2022
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added this to the 5.0.1 milestone Feb 11, 2022
@raimund-schluessler raimund-schluessler changed the title Fix shrinking of last breadcrumb for narraow width Fix shrinking of last breadcrumb for narrow width Feb 11, 2022
@raimund-schluessler raimund-schluessler marked this pull request as ready for review February 11, 2022 21:09
@raimund-schluessler raimund-schluessler added the 3. to review Waiting for reviews label Feb 11, 2022
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! :)
Btw, at a certain width, should the "Home" icon maybe also be ellipsized into the 3-dot action menu?

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, didnt test it

@raimund-schluessler
Copy link
Contributor Author

Btw, at a certain width, should the "Home" icon maybe also be ellipsized into the 3-dot action menu?

I don't have a strong opinion on this. It would save anouther 64 px in width, which would enable showing a bit more of the last folders name. But I am not sure if it's necessary.

This is how it looks on iPhone8.
Currently:
Screenshot 2022-02-14 at 13-42-02 Inventar - Nextcloud
Without the Home icon:
Screenshot 2022-02-14 at 13-44-47 Inventar - Nextcloud

@raimund-schluessler raimund-schluessler merged commit dc14a71 into master Feb 14, 2022
@raimund-schluessler raimund-schluessler deleted the fix/noid/breadcrumbs-last-child branch February 14, 2022 12:49
@jancborchardt
Copy link
Contributor

@raimund-schluessler yeah, just a thought, we can see if that ever comes up, then we cpuld do that. :)

@raimund-schluessler raimund-schluessler modified the milestones: 5.0.1, 5.1.0 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: breadcrumbs Related to the breadcrumbs components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants