Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button native type prop on <Button> #2516

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Add button native type prop on <Button> #2516

merged 1 commit into from
Feb 25, 2022

Conversation

tcitworld
Copy link
Contributor

Allows to have <Button native-type="submit">Send</Button> in a form and listen on the @submit event instead of the @click one.

@tcitworld
Add button native type prop on <Button>
48d1d07 
Allows to have `<Button native-type="submit">Send</Button>` in a form and
listen on the `@submit` event instead of the `@click` one.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added enhancement New feature or request 3. to review Waiting for reviews labels Feb 22, 2022
@tcitworld tcitworld added this to In progress in Thomas things to do via automation Feb 22, 2022
@ChristophWurst
Copy link
Contributor

@JuliaKirschenheuter didn't you also make this suggestion because it would handle some accessibility aspects better?

Thomas things to do automation moved this from In progress to Reviewer approved Feb 25, 2022
@ChristophWurst ChristophWurst merged commit 304f16b into master Feb 25, 2022
Thomas things to do automation moved this from Reviewer approved to Done Feb 25, 2022
@ChristophWurst ChristophWurst deleted the add-button-native-type-props branch February 25, 2022 15:44
@ChristophWurst ChristophWurst added this to the 5.1.0 milestone Feb 25, 2022
@raimund-schluessler raimund-schluessler mentioned this pull request Feb 28, 2022
Closed
@skjnldsv skjnldsv removed this from Done in Thomas things to do Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tcitworld @ChristophWurst @JuliaKirschenheuter @marcoambrosini