show the action buttons on top of the modal always by default

[szaimen]

reason behind this: as noticed in the accessibility workshop, the action buttons of the modal should always visible. Changing the default to -1 will allow to opt-in into the hiding of the action buttons which is in my opinion the better way to do this.

Signed-off-by: szaimen szaimen@e.mail.de

[skjnldsv]

This is a breaking change @jancborchardt

[jancborchardt]

@szaimen could you add before/after screenshot / gif? I don’t really understand what it does.

@skjnldsv why is this a breaking change?

[szaimen]

@szaimen could you add before/after screenshot / gif? I don’t really understand what it does.

Maybe @skjnldsv can? :)

[skjnldsv]

@skjnldsv why is this a breaking change?

Because all Modals that were relying on auto-hiding the UI will now have to manually specify the timeout.

[szaimen]

@jancborchardt these navigation items of the modal:

hide by default after 3s if you don't move your mouse which is bad for mobile and accessibility wise.

After this change they are always visible by default if the developer did not specify a timeout which will hide these items again after a specific timeout...

Hope that is clear now? :)

[jancborchardt]

Which of our modals would still use auto-hide here then, if any?

Cause as it came up in the accessibility workshop I would say we should remove the auto-hiding altogether. The close button should always be visible, and if a name is needed that one should also be shown (or not set in the first place), but not hide.

This should not be configurable by individual developers.

[szaimen]

This should not be configurable by individual developers.

So then shall I remove this option?

cc @skjnldsv

[szaimen]

ping @skjnldsv
for me it is fine to only change the default for now. WDYT? :)

[skjnldsv]

I'm following Jan's decision :)
If the workshop suggested we should remove, let's set the default to disabled or remove the feature

[szaimen]

If the workshop suggested we should remove, let's set the default to disabled or remove the feature

I've already set the default to disabled but tried to remove it now in the latest commit. Please suggest what is your choice. Depending on that I'll revert the last commit again.

This is now best reviewed like this: https://github.com/nextcloud/nextcloud-vue/pull/2630/files?diff=unified&w=1

[ChristophWurst]

👍 🐘

please squash

[szaimen]

please squash

done