Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title section to settingsdialog #2719

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Add title section to settingsdialog #2719

merged 2 commits into from
Jun 2, 2022

Conversation

marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Jun 2, 2022 •
edited

..Also gets rid of the annoying title without top margin when scrolling into view

Screen.Recording.2022-06-02.at.16.05.09.mov

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

@marcoambrosini marcoambrosini added enhancement New feature or request 2. developing Work in progress feature: settings Related to the settings component labels Jun 2, 2022
@marcoambrosini marcoambrosini added this to the 5.3.2 milestone Jun 2, 2022
@marcoambrosini marcoambrosini self-assigned this Jun 2, 2022
@skjnldsv skjnldsv force-pushed the feature/1709/add-title-to-settings-dialog branch from cdac1bb to 42e3c4e Compare June 2, 2022 12:54
@marcoambrosini marcoambrosini force-pushed the feature/1709/add-title-to-settings-dialog branch 3 times, most recently from d131e52 to ece6e1b Compare June 2, 2022 14:03
skjnldsv and others added 2 commits June 2, 2022 16:08
@skjnldsv @marcoambrosini
Add title section to settingsdialog
22a2f86 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@marcoambrosini
Use padding instead of margin in section titles
f1480a9 
this will scroll into view the element with some whitespace
on top upon cliching a navigation entry

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini force-pushed the feature/1709/add-title-to-settings-dialog branch from c7eb826 to f1480a9 Compare June 2, 2022 14:08
@marcoambrosini marcoambrosini added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 2, 2022
GretaD
GretaD approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, didnt test it

@skjnldsv skjnldsv merged commit c1ee49d into master Jun 2, 2022
@skjnldsv skjnldsv deleted the feature/1709/add-title-to-settings-dialog branch June 2, 2022 15:25
@skjnldsv skjnldsv modified the milestones: 5.3.2, 5.4.0 Jun 2, 2022
@raimund-schluessler raimund-schluessler mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@szaimen szaimen Awaiting requested review from szaimen

@artonge artonge Awaiting requested review from artonge

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews enhancement New feature or request feature: settings Related to the settings component
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcoambrosini @GretaD @skjnldsv