Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with Multiselect component #2895

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Fix issues with Multiselect component #2895

merged 2 commits into from
Jul 27, 2022

Conversation

nickvergessen
Copy link
Contributor

@nickvergessen nickvergessen commented Jul 27, 2022 •
edited

Fix step 3 of #2891

  1. ❌ Error: Element div not allowed as child of element span in this context. (Suppressing further errors from this subtree.)
  2. Loading icon background color issue
Before After
Peek 2022-07-27 10-39 Peek 2022-07-27 10-38

@nickvergessen
Fix HTML validation of Multiselect component
2840a42 
* Error: Element div not allowed as child of element span in this context. (Suppressing further errors from this subtree.)

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jul 27, 2022
@nickvergessen nickvergessen force-pushed the bugfix/2891/no-div-inside-span branch from 2e111fe to 4a5ee80 Compare July 27, 2022 08:42
raimund-schluessler
raimund-schluessler approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. But where does the wrong background of the loading icon come from?

@nickvergessen
Copy link
Contributor Author

okay.. thanks for resisting one more time.
Now I found the correct spot

@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 27, 2022
@nickvergessen
Fix background color of loading spinner
e790a3e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/2891/no-div-inside-span branch from 4a5ee80 to e790a3e Compare July 27, 2022 09:02
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 27, 2022
@marcoambrosini marcoambrosini merged commit c7c4cd0 into master Jul 27, 2022
@marcoambrosini marcoambrosini deleted the bugfix/2891/no-div-inside-span branch July 27, 2022 14:17
@nickvergessen nickvergessen mentioned this pull request Jul 28, 2022
Closed
2 tasks
@juliushaertl juliushaertl mentioned this pull request Aug 2, 2022
Closed
@nickvergessen
Copy link
Contributor Author

/backport to stable5

@backportbot-nextcloud
Copy link

The backport to stable5 failed. Please do this backport manually.

@nickvergessen nickvergessen mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @raimund-schluessler @marcoambrosini