Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button import in modal example #2984

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Fix button import in modal example #2984

merged 1 commit into from
Aug 9, 2022

Conversation

raimund-schluessler
Copy link
Contributor

This fixes the broken styleguide after #2953. Button was renamed to ButtonVue in #2980 because eslint complained. So importing it as Button does not work anymore and breaks the styleguide.

@raimund-schluessler
Fix button import in modal example
332df3a 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: documentation Related to the documentation feature: modal Related to the modal component labels Aug 9, 2022
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 9, 2022
@raimund-schluessler raimund-schluessler mentioned this pull request Aug 9, 2022
Merged
@raimund-schluessler raimund-schluessler mentioned this pull request Aug 9, 2022
Merged
GretaD
GretaD approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from the comment

@raimund-schluessler raimund-schluessler merged commit 01454dc into master Aug 9, 2022
@raimund-schluessler raimund-schluessler deleted the fix/noid/modal-import-button branch August 9, 2022 15:07
@juliushaertl juliushaertl mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@vinicius73 vinicius73 vinicius73 approved these changes

@GretaD GretaD GretaD approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@Pytal Pytal Awaiting requested review from Pytal

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: documentation Related to the documentation feature: modal Related to the modal component
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@raimund-schluessler @ChristophWurst @vinicius73 @GretaD @skjnldsv