Fix Actions styling in Breadcrumbs #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
bug
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/2988/breadcrumbs-actions
branch
from
0ef453f
to
476018a
Compare
ChristophWurst
approved these changes
Aug 10, 2022
raimund-schluessler
requested review from
juliushaertl,
GretaD,
Pytal,
marcoambrosini and
skjnldsv
JuliaKirschenheuter
approved these changes
Aug 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes (and simplifies) the styling of the
Actionscomponent in theBreadcrumbscomponent, which is broken due to #2911. To allow to re-use theButtonVuestyling, I allowed to forward thetypeprop from theActionsto theButtonVuecomponent.Closes #2988.
Before:
After:
