Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a native datetime picker #3063

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Aug 18, 2022

resolves #1666

Working version with attributes value, min, max (types): date, datetime-local, month, time, week.

ToDo / Bugs for "upstream", native implementation are described in #1666

ToDo / Bugs to fix for "wrapper" - NativeDatetimePicker component:

  • Check if input value is not allowed -> prevent NaN return value.
  • Complete the documentation / check if it works well (right now i'm not able to build a documentation).

Screenshots:
image
image
image
image
image

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Aug 18, 2022
@JuliaKirschenheuter JuliaKirschenheuter added the 2. developing Work in progress label Aug 18, 2022
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review August 26, 2022 08:03
@ChristophWurst ChristophWurst changed the title Add first version of NativeDatetimePicker.vue Add a native datetime picker Aug 26, 2022
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 26, 2022
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested briefly using our calendar app and left some feedback.

I thought we would replace the old DateTimePicker entirely instead of creating a new component. Are there specific reasons to create a new component and keep the old component?

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. Didn't test.

src/components/NcActionInput/NcActionInput.vue Outdated Show resolved Hide resolved
src/components/NcActionInput/NcActionInput.vue Outdated Show resolved Hide resolved
@ChristophWurst

This comment was marked as resolved.

Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@ChristophWurst ChristophWurst added this to the 6.0.0 milestone Sep 1, 2022
@ChristophWurst ChristophWurst added enhancement New feature or request component Component discussion and/or suggestion feature: datepicker Related to the date/time picker component labels Sep 1, 2022
@JuliaKirschenheuter
Copy link
Contributor Author

I thought we would replace the old DateTimePicker entirely instead of creating a new component. Are there specific reasons to create a new component and keep the old component?

I would like to start slowly and won't create a big breaking change. Reason: a new picker have to be tested in several places / components. We could do this step a bit later.

@ChristophWurst
Copy link
Contributor

A working demo can be found at nextcloud/mail#7123.

@juliushaertl juliushaertl modified the milestones: 6.0.0, 7.0.0 Sep 1, 2022
@juliushaertl
Copy link
Contributor

Note we branched off a stable6 branch and master will be the next major only compatible with Nextcloud 25+, so if needed please backport this pr also to stable6.

@ChristophWurst
Copy link
Contributor

/backport to stable6

Copy link
Contributor

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Just some non-blocking nit-picks

Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this

Add documentation for NcDateTimePickerNative.vue

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews component Component discussion and/or suggestion enhancement New feature or request feature: datepicker Related to the date/time picker component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV/A11Y] Datetime picker UX needs to be improved.
6 participants