Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emptyContent once more #3106

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Fix emptyContent once more #3106

merged 1 commit into from
Aug 26, 2022

Conversation

jotoeri
Copy link
Contributor

@jotoeri jotoeri commented Aug 26, 2022

  • Now went back to the action slot, so action and description can be properly formatted here on the component.
  • The description also became a prop, thus beeing consistent with the title.
  • Adapting resp. docs
  • Adapting Usage within DashboardWidget

I considered alternatively to make the old description slot a flex-element for centering items, that however didn't allow me to put some margin between text and action here on the component. So apps would have needed to separately style the distance between.

Before After
Screenshot from 2022-08-26 09-03-28 Screenshot from 2022-08-26 08-50-34

@jotoeri jotoeri added 3. to review Waiting for reviews feature: emptycontent Related to the emptycontent component breaking PR that requires a new major version labels Aug 26, 2022
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! 👍

Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews breaking PR that requires a new major version feature: emptycontent Related to the emptycontent component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants