Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single action detection #3212

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

st3iny
Copy link
Contributor

@st3iny st3iny commented Sep 9, 2022

The detection relies on the tag we use in our compontent instead of the "real" component name. In calendar we did not change every tag to NcAction... but just changed imports instead. As a result the detection is broken and the ... menu is always shown.

Before After
image image

@st3iny st3iny added bug Something isn't working 3. to review Waiting for reviews labels Sep 9, 2022
@st3iny st3iny added this to the 7.0.0 milestone Sep 9, 2022
@st3iny st3iny self-assigned this Sep 9, 2022
@raimund-schluessler
Copy link
Contributor

In calendar we did not change every tag to NcAction... but just changed imports instead.

Then go change your component tags 😄🙈

Fine with me, I am just not sure how reliable this is, so I would propose to keep the tag as a fallback at least. But I don't like this componentOptions magic anyway (I didn't find a good documentation for it yet either), so it's probably also ok without.

@st3iny
Copy link
Contributor Author

st3iny commented Sep 9, 2022

In calendar we did not change every tag to NcAction... but just changed imports instead.

Then go change your component tags smilesee_no_evil

Fine with me, I am just not sure how reliable this is, so I would propose to keep the tag as a fallback at least. But I don't like this componentOptions magic anyway (I didn't find a good documentation for it yet either), so it's probably also ok without.

That is easier said than done. You're welcome to migrate and test all of our components :P

@raimund-schluessler
Copy link
Contributor

In calendar we did not change every tag to NcAction... but just changed imports instead.

Then go change your component tags smilesee_no_evil
Fine with me, I am just not sure how reliable this is, so I would propose to keep the tag as a fallback at least. But I don't like this componentOptions magic anyway (I didn't find a good documentation for it yet either), so it's probably also ok without.

That is easier said than done. You're welcome to migrate and test all of our components :P

Nah, thanks. I did it for nextcloud/vue and for Tasks, this was enough tedious renaming action for me 😉

@raimund-schluessler
Copy link
Contributor

/backport to stable6

@st3iny st3iny force-pushed the fix/noid/single-action-detection branch from 1eb2593 to 7da6041 Compare September 9, 2022 12:54
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/noid/single-action-detection branch from 7da6041 to a535ac0 Compare September 9, 2022 12:54
@st3iny st3iny merged commit 6b8b1b2 into master Sep 9, 2022
@st3iny st3iny deleted the fix/noid/single-action-detection branch September 9, 2022 13:20
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants