Add button role for NcButton with href

[Pytal]

Attribute role="button" added for anchor element in NcButton with href and fixed the invalid type="button" attr being added to the DOM when using NcButton as a link https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-type

router-link is rendered as a button element https://v3.router.vuejs.org/api/#tag

[raimund-schluessler]

@Pytal Are you sure, this is necessary? Looking at nextcloud/server#35527 I suppose this is about passing href to the NcButton. But that should work already by passing the propsData here:
https://github.com/nextcloud/nextcloud-vue/blob/4e8546981baa32b3c1ec34825fa3a7f02db182d7/src/components/NcActions/NcActions.vue#L949
At least in the docs, a single NcActionLink with href set correctly becomes a NcButton of type link with the href present.

[Pytal]

This is for the attribute role="button" from this comment as it is not included in propsData @raimund-schluessler, open to ideas if another way is better?

[raimund-schluessler]

This is for the attribute role="button" from this comment as it is not included in propsData @raimund-schluessler, open to ideas if another way is better?

If role="button" is necessary, maybe it's a good idea to add it to NcButton by default? @skjnldsv what do you think?

[Pytal]

Probaby here
https://github.com/nextcloud/nextcloud-vue/blob/288d451dc68303ee4f8b6ef491277ec60921e321/src/components/NcButton/NcButton.vue#L330-L334
then?

Will wait for input from @skjnldsv

[skjnldsv]

If role="button" is necessary, maybe it's a good idea to add it to NcButton by default? @skjnldsv what do you think?

Absolutely 👍