Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more space for unread counter so its aligned with action menu #3572

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Add more space for unread counter so its aligned with action menu #3572

merged 1 commit into from
Dec 15, 2022

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Dec 15, 2022 •
edited by ChristophWurst

For nextcloud/mail#7769

i tested with mail and tasks

@GretaD
Add more space for unread counter so its aligned with action menu
0377d28 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD
Copy link
Contributor Author

GretaD commented Dec 15, 2022

@marcoambrosini please check since you added the first value

@GretaD GretaD self-assigned this Dec 15, 2022
@GretaD GretaD added 3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design labels Dec 15, 2022
@ChristophWurst
Copy link
Contributor

screenshots?

@marcoambrosini
Copy link
Contributor

Screenshot 2022-12-15 at 16 32 08

marcoambrosini
marcoambrosini approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@raimund-schluessler raimund-schluessler merged commit 9fcc733 into master Dec 15, 2022
@raimund-schluessler raimund-schluessler deleted the fix/unread-counter-position branch December 15, 2022 15:42
@ChristophWurst ChristophWurst mentioned this pull request Dec 15, 2022
Closed
@GretaD GretaD mentioned this pull request Dec 16, 2022
Merged
1 task
@jotoeri jotoeri added this to the 7.3.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@GretaD GretaD

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GretaD @ChristophWurst @marcoambrosini @raimund-schluessler @jotoeri