Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action input styles #3614

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix action input styles #3614

merged 1 commit into from
Jan 5, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jan 5, 2023

Before After
image image
image image

@Pytal
Fix action input styles
bc330c7 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews labels Jan 5, 2023
@Pytal Pytal added this to the 7.3.1 milestone Jan 5, 2023
@Pytal Pytal self-assigned this Jan 5, 2023
@Pytal Pytal mentioned this pull request Jan 5, 2023
Closed
6 tasks
PVince81
PVince81 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raimund-schluessler
Copy link
Contributor

MIght be a good idea to use an NcInputField for the action input fields to get the same styling.

@skjnldsv skjnldsv merged commit 8105cc5 into master Jan 5, 2023
@skjnldsv skjnldsv deleted the fix/action-input-style branch January 5, 2023 09:37
@skjnldsv skjnldsv mentioned this pull request Jan 11, 2023
Merged
@skjnldsv skjnldsv modified the milestones: 7.3.1, 7.4.0 Jan 11, 2023
@skjnldsv skjnldsv mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pytal @raimund-schluessler @PVince81 @skjnldsv