Add node-polyfill-webpack-plugin

[GretaD]

fixes #3696

[GretaD]

i cannot run npm right now, will check tomorrow again

[ChristophWurst]

I think this should be a peer dependency

Otherwise 👍

[GretaD]

I think this should be a peer dependency

Otherwise +1

right, but we only have dependencies and devDependencies here, so should i switch to Dependencies?

[ChristophWurst]

peerDependencies

[raimund-schluessler]

peerDependencies

While technically correct, listing this as a peer dependency is very likely a breaking change. Every app using nextcloud/vue will have to have this peer dependency in their dependency list. Otherwise npm will probably warn about it. I don't know how that behaves when node-polyfill-webpack-plugin is already installed as a dependency of another package (e.g. nextcloud/webpack-config), though.

But to keep it pragmatic, I would just list it as a dependency, to be honest.

[ChristophWurst]

npm installs peers automatically, doesn't it?

adding it as dev dep is also fine 👍

[raimund-schluessler]

npm installs peers automatically, doesn't it?

Indeed, it seems this feature came back with npm v7, it was gone since npm v3. As npm v7 is the lowest supported version here, it's probably fine. But I didn't test it.

[raimund-schluessler]

@GretaD You put it in devDependencies now. I think this will not work. And please order it alphabetically 🙂🙈

[GretaD]

@GretaD You put it in devDependencies now. I think this will not work. And please order it alphabetically slightly_smiling_facesee_no_evil

yes, thats what christoph proposed and you did not object on your comment. Changing it again then

[raimund-schluessler]

@GretaD You put it in devDependencies now. I think this will not work. And please order it alphabetically slightly_smiling_facesee_no_evil

yes, thats what christoph proposed and you did not object on your comment. Changing it again then

Ah, yes, sorry. I missed this. I think a development dependency will not work as they are afaik not installed for the peer. Did you try it with a dev dep and it worked?

[GretaD]

@GretaD You put it in devDependencies now. I think this will not work. And please order it alphabetically slightly_smiling_facesee_no_evil

yes, thats what christoph proposed and you did not object on your comment. Changing it again then

Ah, yes, sorry. I missed this. I think a development dependency will not work as they are afaik not installed for the peer. Did you try it with a dev dep and it worked?

no i didnt test it on devDep, sorry 🙈

[raimund-schluessler]

Then let's hope adding it as a dependency works 🙂 🙈