Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select styles #3854

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fix select styles #3854

merged 1 commit into from
Mar 7, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Mar 3, 2023

Ensure that the styles are always applied correctly

Before After
image image

The "Before" image shows the share select in https://github.com/nextcloud/server master after opening a file in viewer

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Mar 3, 2023
@Pytal Pytal added this to the 7.9.0 milestone Mar 3, 2023
@Pytal Pytal self-assigned this Mar 3, 2023
@raimund-schluessler raimund-schluessler modified the milestones: 7.9.0, 7.8.1 Mar 4, 2023
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use !important in all places? I can for possible other solution

@raimund-schluessler
Copy link
Contributor

should we use !important in all places? I can for possible other solution

Ideally, we should not use it at all. I know it's sometimes necessary, or rather easier, but I would prefer to limit its usage to the places where we have issues.

@skjnldsv
Copy link
Contributor

skjnldsv commented Mar 7, 2023

should we use !important in all places? I can for possible other solution

Ideally, we should not use it at all. I know it's sometimes necessary, or rather easier, but I would prefer to limit its usage to the places where we have issues.

We could be using a scoped styling with vdeep. It should have a higher selector level?

@skjnldsv skjnldsv merged commit 3672a9c into master Mar 7, 2023
@skjnldsv skjnldsv deleted the fix/select-styles branch March 7, 2023 08:08
@susnux
Copy link
Contributor

susnux commented Mar 7, 2023

I agree !important should be used rarely, but for the moment I can only think of one possible "bigger" issue with this:
The enforcement of the primary color on the border, as this makes it hard to assign an error state for custom validation of NcSelect.

@julien-nc julien-nc mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants