Properly style timezone select in NcDatetimePicker #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
bug
raimund-schluessler
requested review from
ChristophWurst,
jancborchardt,
artonge,
skjnldsv,
Pytal and
hamza221
raimund-schluessler
added
3. to review
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/noid/datepicker-timezone-select
branch
from
5e4286e
to
567baef
Compare
artonge
approved these changes
Apr 27, 2023
nimishavijay
previously requested changes
Apr 27, 2023
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Done. |
ChristophWurst
approved these changes
Apr 27, 2023
hamza221
approved these changes
Apr 27, 2023
raimund-schluessler
dismissed
nimishavijay’s stale review
Changes requested where implemented.
raimund-schluessler
added
the
design
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the styling of the timezone-picker popover to align with the
NcActionscomponent. It also fixes the timezone list being hidden behind the popover.Closes nextcloud/calendar#5143