Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slash in CLI URL required #652

Closed
TomTurnschuh opened this issue Sep 28, 2018 · 2 comments
Closed

Trailing slash in CLI URL required #652

TomTurnschuh opened this issue Sep 28, 2018 · 2 comments
Assignees
@nachoparker
Labels
bug

Comments

@TomTurnschuh
Copy link
Contributor

In order for nc_prettyURL to work, the domain in overwrite.cli.url must have a trailing / – at least, if the domain has no path, cf. nextcloud/server#10678. Hence, a trailing / should be added in all apps where overwrite.cli.url is defined.
@TomTurnschuh
Copy link
Contributor Author

I just upgraded to NC14.0.1 and PHP7.2 and noticed that prettyURLs are not working. Will have to look into this later, maybe that's the reason.

Yes, this is probably the reason. It works if you add the trailing slash in overwrite.cli.url. I opened a pull request to catch this error as a first step.

@nachoparker
Copy link
Member

fixed in devel, thanks!

@nachoparker nachoparker self-assigned this Oct 1, 2018
@nachoparker nachoparker added the bug label Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nachoparker nachoparker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nachoparker @TomTurnschuh