Code visualization with inline code and code blocks buggy

[HagenMorano]

Describe the bug
There are basically two issues with the coloring and displaying of inline code and code blocks (markdown):

1. Inline Code (`example`) gets cut in view mode when too long (see screenshot 2)
2. Color contrast of code blocks is very low on both view and edit mode (only tested on dark mode, see screenshot 1 & 2), also there are some dark ugly fragments in view mode (screenshot 2)
   ```
   example
   ```

To Reproduce
Steps to reproduce the behavior:

1. Create a long inline code
2. Create a code block in dark mode

Expected behavior
Concerning inline code: Line should break
Concerning code block: Colors should be more contrasting

Screenshots

Edit mode:

View mode:

Smartphone

• Nextcloud Notes-Version (android app): 2.17.1
• F-Droid or Play Store: Play Store
• Android-Version: 10
• Device: Xiaomi Mi Mix 2s

Server

• Nextcloud version: 20.0.3
• Nextcloud Notes version (server app): 4.0.1

[stefan-niedermann]

Uhmm 🤔 i can't reproduce this issue. On my device as well as on any emulator i use, the colors are correct.

Can you maybe tell me more about your Android settings like system wide dark mode, automatic night mode, display color adjustments and so on? Have you changed any default configuration of your Android system (to be clear: I am not talking about the App settings)?

Is the text readable in light mode? Which theme have you set in the app? "Dark" or "System default"?

[stefan-niedermann]

cc @dan0xii

[HagenMorano]

The only relevant setting I can see is the global dark mode. If set to dark, switching the theme in the application has no effect (dark,light and system default all result in a dark mode), switching global dark mode to light results in a desired behaviour: light and system default result in a light theme, dark results in a dark theme (expected behaviour).

Light theme looks good regarding colors but long inline codes are also cut.

There is one more UI relevant setting I can see in the dev settings: Turn on MIUI optimization which also seems to have no effect.

Also I don't remember changing any system settings concerning colors etc. (except dark mode)

Maybe the problem gets resolved within #549 ?

[stefan-niedermann]

Maybe the problem gets resolved within #549 ?

I hope so, though the preview mode will still take some time to get implemented. But it would be very helpful if you could check the behavior of 2.18.1 (available at the Play Store Beta channel) to see whether this already fixes the issue at the editor. 🙂

So long, stay well and merry X-Mas 🙂

[HagenMorano]

Thanks for the quick reply! Just checked out beta version, but no changes concerning this issue unfortunately.

The issue is no show stopper as I am personally using backtick comments on laptop which is working quite good.

Merry Christmas to you too 🎄

[stefan-niedermann]

Would you mind adding a screenshot of v2.18.1 editor?

[HagenMorano]

Sure - after restarting application I just realized that edit mode now is indeed looking better - also font is now monospace. Like! See screenshots

[stefan-niedermann]

Should be fixed in v2.19.0 (available soon at the Play Store beta channel and on F-Droid). Please reopen this issue in case it is still a problem with this version 🙂

And thanks for the helpful screenshots!

[HagenMorano]

Confirm 👍 Thanks a lot!