-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Synced Conversations splitted in two #6
Comments
Can you give me a screen of your ownCloud app render (blur the sensible parts) ? Thanks |
You have the two aspects of the same conversation here : |
Ok, that's what i thought. I will look at this problem this week, it need some improvements on Android code with new parameters and new account creation model. http://www.codeofaninja.com/2013/01/android-libphonenumber-example.html?showComment=1360110523169 |
can't wait to see that :) thx |
@theonlydoo i will work on it this afternoon, if no problem. |
nice @nerzhul thx |
@theonlydoo if you use actual master branch, does this fix your issue ? I don't fix client side is the better idea ? |
hey @nerzhul sorry for the late response, quite a busy day. |
n.b. I git pulled the update you pushed, it putted oc in maintenance mode for a while and updated the app. |
i have 3k sms but not in a conversation. |
For merging conversation, be sure you have intl number + local number in the same contact, this will merge the conversation properly and evade phone number conversion problem on android |
I'll truncate the table, to see if it fixes that bug. |
truncate table, up2date apps : still a problem. The problem seems different now though, I do have a single conversation by contact, but there is no messages from me ... except maybe one or two by conversation 😬 |
erf... if you look in the database you see all messages for the conversation ? |
nope |
then the client doesn't see your messages. Are these SMS or MMS ? At this time only SMS are synced |
it's mostly an SMS conversation |
I tried to truncate and sync again, and I got the error |
Error 3 means that the push request failed. Is there any messages in you owncloud.log or apache/error.log ? |
I'll try to truncate and sync with tail -f on both logs, and I'll keep you posted ! |
Hellow, sorry for the delay, I was kind of swamped those days. |
No problem. |
Indeed, the database has exactly the same datas |
Ok, i think it's a problem on client, but the client lists every SMS message, i think somes are formated as MMS and i need to add support faster |
That's possible indeed, since a lot of my sms are actually 5 or 6 sms one shot |
then they are MMS. Android convert SMS to MMS when they use 3 sms and more, as i can remember. |
I'll take your word for that :) Keep me posted if you need to run other tests. |
Thanks. I'll try to add support for MMS (text in first phase) since 2 weeks. |
ok, i change the milestone. We need to push it into 1.3 because it's a new feature. 1.2 merge is now closed |
No problem, good luck ! |
Can you test the situation for your SMS messages with 8d28751 please ? |
Hey, I git pulled and got the HEAD revision (which is 0e013b0, after 8d28751). The long message issue seem to be fixed, but :
|
Hi, |
You mean you have more messages on ocsms instance than your phone ? Just an idea "on the fly" : can't you match the X last digits of a phone number ? The probability of a mismatch between two numbers from two different country is really thin. |
In fact the problem is each country has its own rules. And if you have international SMS you can have unsollicited merged conversations. a09faa6 must fix your duplicated numbers into conversation, can you test it ? |
Nope, does not fix (I truncated the table) :-( |
Can you tell me what you see into conversation ? (replace 4 last digits by letters (1 letter per digit)) |
I see the same thing that was displayed before, since I've got the "normal" phone number associated to the contact in my address book : My SMS are displayed under 06xxxxxxxx and the contact SMS are displayed under +336xxxxxxxx, I'll try to add the +33 number to the contact to see if it merges. Do you know how Android handles the Local/International format issue on it's conversation app ? |
Yep, this workaround does the trick ! |
Android uses it's own library . I found a JAVA library developped by Google which permit to convert local numbers to intl numbers. I think having a workaround on the Android app can be good, but it's not the first thing i must develop. |
OK, done here nerzhul/ncsms-android#3 |
Server
Client
Like i said in here : #1 (comment)
I have a few more problems about sync : the first one is that the large conversation that I have by text message with my GF are split in two. The first part is her talking, the second, in a second conversation, is mine.
The text was updated successfully, but these errors were encountered: