Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos app breaks PROPFIND #2116

Closed
ShGKme opened this issue Nov 9, 2023 · 1 comment · Fixed by #2104
Closed

Photos app breaks PROPFIND #2116

ShGKme opened this issue Nov 9, 2023 · 1 comment · Fixed by #2104
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Nov 9, 2023

Describe the bug

Enabling the Photos app breaks PROPFIND requests.

Both server and photos on the current master.

To Reproduce
Steps to reproduce the behavior:

  1. Enable Photos
  2. Open "Files" root, or "Personal Settings / Availability"
  3. See errors and no data
  4. Failed requests:
    • 500 PROPFIND /remote.php/dav/files/admin/
      • No response
    • 500 PROPFIND /remote.php/dav/calendars/admin/inbox
      • Too few arguments to function OCA\Photos\Sabre\PropFindPlugin::__construct(), 0 passed in /var/www/html/apps/dav/lib/AppInfo/PluginManager.php on line 262 and exactly 4 expected
  5. Log:
{
  "reqId": "1RvjftyW8gL4IsouUwsN",
  "level": 3,
  "time": "2023-11-09T10:58:23+00:00",
  "remoteAddr": "46.5.137.247",
  "user": "admin",
  "app": "webdav",
  "method": "PROPFIND",
  "url": "/remote.php/dav/calendars/admin/inbox",
  "message": "Too few arguments to function OCA\\Photos\\Sabre\\PropFindPlugin::__construct(), 0 passed in /var/www/html/apps/dav/lib/AppInfo/PluginManager.php on line 262 and exactly 4 expected",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36",
  "version": "28.0.0.4",
  "exception": {
    "Exception": "ArgumentCountError",
    "Message": "Too few arguments to function OCA\\Photos\\Sabre\\PropFindPlugin::__construct(), 0 passed in /var/www/html/apps/dav/lib/AppInfo/PluginManager.php on line 262 and exactly 4 expected",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/html/apps/dav/lib/AppInfo/PluginManager.php",
        "line": 262,
        "function": "__construct",
        "class": "OCA\\Photos\\Sabre\\PropFindPlugin",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/apps/dav/lib/AppInfo/PluginManager.php",
        "line": 277,
        "function": "createClass",
        "class": "OCA\\DAV\\AppInfo\\PluginManager",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "function": "OCA\\DAV\\AppInfo\\{closure}",
        "class": "OCA\\DAV\\AppInfo\\PluginManager",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/html/apps/dav/lib/AppInfo/PluginManager.php",
        "line": 282,
        "function": "array_map",
        "args": [
          [
            "Closure"
          ],
          [
            "*** sensitive parameters replaced ***"
          ]
        ]
      },
      {
        "file": "/var/www/html/apps/dav/lib/AppInfo/PluginManager.php",
        "line": 156,
        "function": "loadSabrePluginsFromInfoXml",
        "class": "OCA\\DAV\\AppInfo\\PluginManager",
        "type": "->",
        "args": [
          [
            "*** sensitive parameters replaced ***"
          ]
        ]
      },
      {
        "file": "/var/www/html/apps/dav/lib/AppInfo/PluginManager.php",
        "line": 107,
        "function": "populate",
        "class": "OCA\\DAV\\AppInfo\\PluginManager",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/apps/dav/lib/Server.php",
        "line": 353,
        "function": "getAppPlugins",
        "class": "OCA\\DAV\\AppInfo\\PluginManager",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
        "line": 89,
        "function": "OCA\\DAV\\{closure}",
        "class": "OCA\\DAV\\Server",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 456,
        "function": "emit",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "beforeMethod:PROPFIND",
          [
            "*** sensitive parameters replaced ***",
            "*** sensitive parameters replaced ***"
          ]
        ]
      },
      {
        "file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 253,
        "function": "invokeMethod",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***",
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 321,
        "function": "start",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/apps/dav/lib/Server.php",
        "line": 370,
        "function": "exec",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/apps/dav/appinfo/v2/remote.php",
        "line": 35,
        "function": "exec",
        "class": "OCA\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/remote.php",
        "line": 172,
        "args": [
          "/var/www/html/apps/dav/appinfo/v2/remote.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/var/www/html/apps/photos/lib/Sabre/PropFindPlugin.php",
    "Line": 63,
    "message": "Too few arguments to function OCA\\Photos\\Sabre\\PropFindPlugin::__construct(), 0 passed in /var/www/html/apps/dav/lib/AppInfo/PluginManager.php on line 262 and exactly 4 expected",
    "exception": {
      "xdebug_message": "<REMOVED>"
    },
    "CustomMessage": "Too few arguments to function OCA\\Photos\\Sabre\\PropFindPlugin::__construct(), 0 passed in /var/www/html/apps/dav/lib/AppInfo/PluginManager.php on line 262 and exactly 4 expected"
  }
}

Expected behavior

Files are loaded, and availability is loaded.

Screenshots

/remote.php/dav/files/admin/

@ShGKme ShGKme added bug Something isn't working 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Nov 9, 2023
@ShGKme ShGKme linked a pull request Nov 9, 2023 that will close this issue
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 9, 2023

Fixed by #2115

@ShGKme ShGKme closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant