Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.1.4.11/4.3 - Media files marked as selected - The checkboxes do not meet the contrast requirements for graphical informative elements depending on the background (1) #2160

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 7 comments · Fixed by #2196
Assignees
Labels
1. to develop Accepted and waiting to be taken care of a11y28checked needed for a11y accessibility help wanted Extra attention is needed

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 29, 2023

Blocked by

as the contrast ratio with the background is below 3:1. It is recommended to place these elements outside of images. The issue also affects unselected checkboxes (see screenshot)

image
image

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-3dbfb7615a-v4-n3

@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title [BITV] 9.1.4.11/4.3 - Media files marked as selected - The checkboxes do not meet the contrast requirements for graphical informative elements depending on the background, as the contrast ratio with the background is below 3:1. It is recommended to place these elements outside of images. The issue also affects unselected checkboxes (see screenshot). (1) [BITV] 9.1.4.11/4.3 - Media files marked as selected - The checkboxes do not meet the contrast requirements for graphical informative elements depending on the background (1) Nov 29, 2023
@susnux susnux transferred this issue from nextcloud/server Nov 30, 2023
@susnux
Copy link
Contributor

susnux commented Nov 30, 2023

Idea: add some blur background to ensure contrast, similar to the dashboard widgets

@JuliaKirschenheuter
Copy link
Contributor Author

@artonge could you please help us with this ticket?

@JuliaKirschenheuter JuliaKirschenheuter added the help wanted Extra attention is needed label Dec 1, 2023
@artonge
Copy link
Collaborator

artonge commented Dec 6, 2023

This was the original design. It got broken due to some change in @nc/vue internal. I should have set up visual tests 🙈.

Shall we go with that?

Before After
Unchecked & Picture hovered Screenshot from 2023-12-06 15-37-17
Unchecked & Checkbox hovered Screenshot from 2023-12-06 15-37-07
Checked & Checkbox hovered Screenshot from 2023-12-06 15-37-02
Checked Screenshot from 2023-12-06 15-37-22

@artonge
Copy link
Collaborator

artonge commented Dec 6, 2023

PR: #2182

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 7, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Dec 13, 2023

Thank you @artonge!

"Unchecked & Picture hovered" and "Checked" still remaining not accessible ;(

I would suggest not to have special hover styles, because they are not relevant for a11y and leave everything only on checked and unchecked state, like:

Before After
Unchecked and Checkbox unhovered and hovered Screenshot from 2023-12-06 15-37-07
Checked and Checkbox unhovered and hovered Screenshot from 2023-12-06 15-37-02

Focus state have to have a double outline (black and white) like on most buttons:

Screenshot from 2023-12-13 17-20-18

In light theme background have to be not dark but light like:

Screenshot from 2023-12-13 17-16-45

@nimishavijay would you approve such solution?

@artonge
Copy link
Collaborator

artonge commented Dec 13, 2023

I would suggest not to have special hover styles, because they are not relevant for a11y and leave everything only on checked and unchecked state, like:

That's what I ended up doing :), but I thought I updated the description 🤔

@nimishavijay
Copy link
Member

Sounds good to me as well. So when you hover over the picture, the checkbox with the background appears, and when you hover over the checkbox, it shows the normal hover feedback for a checkbox component. Would that work? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of a11y28checked needed for a11y accessibility help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants