Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer adjustments #22

Closed
2 tasks done
jakobroehrl opened this issue Dec 5, 2019 · 6 comments
Closed
2 tasks done

Viewer adjustments #22

jakobroehrl opened this issue Dec 5, 2019 · 6 comments
Assignees
@skjnldsv @jakobroehrl
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working high High priority
Projects
Roadmap Distribution
Milestone
1.0.0

Comments

@jakobroehrl
Copy link
Contributor

jakobroehrl commented Dec 5, 2019 •
edited by Mikescops

grafik

  • Close Icon is wrong, should be a x
  • Can't open the sidebar:
    TypeError: Cannot read property 'fileList' of undefined
    at showSidebar (Viewer.vue:569)
@jakobroehrl jakobroehrl added the 1. to develop Accepted and waiting to be taken care of label Dec 5, 2019
@jakobroehrl jakobroehrl added this to the 1.0.0 milestone Dec 5, 2019
@jakobroehrl jakobroehrl self-assigned this Dec 6, 2019
@jakobroehrl jakobroehrl mentioned this issue Dec 6, 2019
Open
6 tasks
@skjnldsv skjnldsv added the bug Something isn't working label Dec 6, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2019

Close button: nextcloud-libraries/nextcloud-vue#757

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2019 •
edited

@jakobroehrl the sidebar open is a quick fix in https://github.com/nextcloud/viewer/blob/2ee76c5e48b1b0517de420169573f60b2841e94a/src/views/Viewer.vue#L569 (you need to use the new OCA.FIles.SIdebar.open function :)

@skjnldsv skjnldsv mentioned this issue Dec 6, 2019
Closed
@jakobroehrl
Copy link
Contributor Author

Tried "OCA.Files.Sidebar.open()" instead of
"OCA.Files.App.fileList.showDetailsView(this.currentFile.basename)"

Now I get
TypeError: Cannot read property 'offsetWidth' of null
at VueComponent.showAppsSidebar (Viewer.vue?a0e8:610)
at VueComponent.showSidebar (Viewer.vue?a0e8:589)
at VueComponent.execFirstAction (Modal.js:1099)
at invokeWithErrorHandling (vue.runtime.esm.js:1854)
at HTMLButtonElement.invoker (vue.runtime.esm.js:2179)
at HTMLButtonElement.original._wrapper (vue.runtime.esm.js:6911)

@skjnldsv
Copy link
Member

@jakobroehrl yes, we need to adapt the script that handle the sidebar width and stuff :)

@jakobroehrl
Copy link
Contributor Author

OK, can I do this?
How hard is that?

@skjnldsv
Copy link
Member

I'm on it already ;)

@skjnldsv skjnldsv self-assigned this Dec 19, 2019
@Mikescops Mikescops added this to To do in Roadmap Distribution Jan 2, 2020
@jancborchardt jancborchardt added the high High priority label Jan 12, 2020
Roadmap Distribution automation moved this from To do to Done Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

@jakobroehrl jakobroehrl

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working high High priority
Projects
Roadmap Distribution
  
Done
Milestone
1.0.0
Development

No branches or pull requests
4 participants
@jancborchardt @Mikescops @skjnldsv @jakobroehrl