Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date separators #45

Closed
skjnldsv opened this issue Dec 16, 2019 · 6 comments · Fixed by #468
Closed

Date separators #45

skjnldsv opened this issue Dec 16, 2019 · 6 comments · Fixed by #468
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request high High priority
Milestone

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Dec 16, 2019

Add date separators/dividers in the timeline view

@skjnldsv skjnldsv added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of labels Dec 16, 2019
@skjnldsv skjnldsv added this to the 1.1.0 milestone Dec 16, 2019
@jancborchardt
Copy link
Member

Simple way to start would be month dividers:

  • January 2020
  • December 2019
  • November 2019
  • etc.

The month dividers are headings, and the year can be shown with grey maxcontrast color to not take so much visibility.

The dividers should be sticky when scrolled down. The container should not have any background color so it simply overlays the images.

@jancborchardt jancborchardt mentioned this issue Dec 30, 2019
14 tasks
@Mikescops Mikescops added this to To do in Roadmap Distribution Jan 2, 2020
@Mikescops
Copy link
Member

I tried to implement this but failed because it needs a totally different data structure from what we have now.
@skjnldsv if you have hints on how to acheive this, would be nice

@jancborchardt
Copy link
Member

@Mikescops for reference, can you explain what the current data structure is, and what we would ideally need?

@Mikescops
Copy link
Member

For now we store what we get from the DAV in a simple array [ ].
It's nice when you have a single sorted list but not when you need to group the entries in it.

For instance i tried this structure:

{
     "2019-12" : [ img1, img2 ],
     "2020-01" : [ img3]
}

It could work well (i tried it), but we need to change lot of stuff, including the way we load more files when reaching the bottom.

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 8, 2020

@Mikescops there is absolutely no rush for it now.
We're also in feature freeze for 18, so thi sis scheduled for the next release anyway :)

We'll talk in person about how to properly implement this if you will

@Mikescops
Copy link
Member

Yes sure, i was considering this as well!

@jancborchardt jancborchardt added the high High priority label Jan 12, 2020
@rullzer rullzer modified the milestones: Nextcloud 20, Nextcloud 21 Oct 3, 2020
@skjnldsv skjnldsv linked a pull request Oct 12, 2020 that will close this issue
Roadmap Distribution automation moved this from To do to Done Oct 12, 2020
@Mikescops Mikescops added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request high High priority
Projects
5 participants