New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create preview problem "No create permission for folder" #121
Comments
I have the same issue, currently using NC 16.0.4 and Version 2.1.0 of the app. Running
Since it's a very large instance, I didn't let |
Hello, Same issue there. I tried to have some more informations but couldn't get more than @loelkes piece of log. Thanks for having a look into it whenever possible :) -- |
I have the sme problem. Please help me solving it! |
Hello SpamReceiver, What filesystem are you using ? -- |
No, it's on a local ext4 mount. |
Yeah, OK. |
The preview generation via OCC is still running and does (so far) not report any issues. But as I am impatient I opened the gallery in the browser and navigated ot a folder which previously had issues. In the nextcloud log I now find the following reports (occ log:watch): ` Error gallery OCP\Files\NotFoundException: at lib/private/Preview/Generator.php line 223 2020-01-02T11:07:09+00:00
` ` Error gallery Exception: Preview generation has failed 2020-01-02T11:08:27+00:00 Error gallery OCP\Files\NotFoundException: at lib/private/Preview/Generator.php line 230 2020-01-02T11:08:27+00:00
` |
What are the permissions/owner for appdata folder ? |
They should be correct, IMO:
|
It seems to me that they are too, but on my instance, the perms also allows the group to write, not only the owner like in your case. |
Hi, Please follow-up : Thanks for your feedback. -- |
Hi Léo! Thanks for asking. |
Aaah sorry, I didn't understand the process was still running :) |
Well, unfortunately not. After running for really long, a few times interrupted by unreadable files, the script now came to a standstill. On a certain JPG file, I receive the "Could not create folder" exception and can't get over it. Here is the output: It's an ext4 filesystem: There are 65,000 sub-directories in the preview directory: |
Hey, Can you access the preview folder and try to create one additionnal file (touch newfile.txt) and see what's the error message ? -- |
Good point: File creation works, but not the creation of a directory. |
OK, so not a permission problem, but same old problem than many people have... but I thought it was for UFS filesystems only. |
I'm not an expert in fs tuning... but it seems like a little bit scary to me :) -- |
So, I did the check proposed in the link and it turned out that I don't have hashed directories: However, I am not willing to change anything on the filesystem just for the previews of the Nextcloud Gallery. Instead, my position is that the preview implementation must be changed so that nobody faces this issue. A change to the implementation can e.g. be to create sub-folders, each containing 1,000 or 32,000 or 64,000 previews. |
After a quick lookup in the code I propose to change the following function: Instead of passing Of course, a migration script will be necessary, too. |
Have you looked at this pull request? Anyway this repository is the wrong place for this discussion. Previewgenerator is using the generation code from nextcloud/server. It's not possible to fix it here. The proposal is accepted. It will probably done with a bigger refactoring of the preview code or before. cc @rullzer I'm not able to close a issue over here ;) |
Now I have had a look at nextcloud/server#16747. It addresses the same issue, so I will be happy to have that fix. |
Give me a break with your contemptuous, haughty tone. The two threads seems to have the same consequences (impossible to generate previews due to filesystems subfolders limits), so refering it here doesn't seem such an mistake for other users looking for informations about it. All developers aren't complete asses when it comes to talk with people and explain why they are mistaking instead of simply grumbling. Seems like you're not one of them. -- |
Take a break ☕ I suggested to have a look at the pull request (the one you mentioned earlier) because that's the right place to discuss about possible solutions. I actually answered to |
Yes, I agree. As I understand the code, the app "PreviewGenerator" relies on the underlying server code for the actual preview generation. The app just triggers the generation for each file. Thus, the management of the previews must be improved in a general manner, and nextcloud/server#16747 addresses this. IMO, you may either close this issue now, or leave it open and mark it as "to be solved by nextcloud/server#16747". The latter has the advantage to potentially avoid new reports for this app. |
I had a similar issue with Nextcloud 22.2.4:
I added a log output in After i checked and the folder did exist for me. So to fix this i added a check on the creation if the folder already exists to fix this and changed it to: |
The original issue seems to be fixed by now. I opened a new issue to address the latest comment because it isn't related to the original issue. |
Hello,
when running whit www user :
php occ preview:pre-generate
the app's stop and the error is :
System is UCS with NC13.04
using
AD integration with Windows Server 2012R2
I have test, modify the permission to the folder to 777, and not resolve the problem,
Thanks for the read,
The text was updated successfully, but these errors were encountered: