error message i am not able to understand #3
Comments
|
same error here, with nginx 1.11 and php7.1-fpm on nextcloud 11 rc2 Do we missing some extension or incompatibility with php7 ? This tool would be awesome if it work, the most needed feature here :-) Cheers :-) |
|
I just upgraded to 11RC2 and still I have this error. |
|
Thanks for reporting. I'll look into it tomorrow. |
|
Mmmm I must say I don't get this when looking at your stack trace. The function at https://github.com/nextcloud/server/blob/master/lib/private/Preview/GeneratorHelper.php#L52 seems to be passed a File. But then when it calls thub.com/nextcloud/server/blob/master/lib/private/Preview/GeneratorHelper.php#L62 the file is suddenly NULL. |
|
Rullzer, thanks for the answer :-) Can you tell what you use? Php version, nextcloud version... System... So probably there are some differences, especially to php version... Cheers:-) |
|
Ps my data folder is not inside nextcloud... It's on other hdd |
|
NC: 11 Mine is also not inside nextcloud. |
|
mmm maybe it is a 7.1 issue. I can test that later hopefully |
|
thank you very much :-) just forgot, im going to check now, php-cli have its own php.ini file and own www.conf file, need to edit it to same as the normal php :-) However, thank you very much :-) |
|
I have a NC 11 instance and my data folder is also not inside the nextcloud folder. apache2 System Debian |
|
yep edited the files, same error xD :-) Just one thing, after clean install of nextcloud 11 (if you upgrade and you copy only config.php, you have an clean directory...) And you execute the script first time, But after that 10minutes, your script abort, with the above error... And if you execute your script again (secound time, third time, and so on) it throws the error immediately... Seems like there are 2 bugs: I have here extremely much pictures (3000-5000) and every picture is about 12-15mb... Im going to try now set memory_limit of php to 8GB and and other limiting php settings to something bigger... Will report later again :-) Thank you anyway for your script :-) |
|
So it's fixed, things i've did: I cant say exactly what fixed this error, i think its the official version of NC11, I cant say if the script will throw error or not, but its running now since 25minutes here is the top log for php:
PS: at this point, some more info from your script would be nice :-) just some output at all would be nice, like how much files are already completed or sth like that :-) Correction: your script is not using much memory, it uses only 60mb of memory or sth like that... About the problem about re executing your script, i cant say at the moment anything, because its still running and not crashed :-) Thank you for your awesome work!!!!! PS: is there any possibility that you can implement a command like "generate-new" Cheers :-) |
|
PS to make it easy for evryone cron job example: sudo crontab -u www-data -e Means execute every day at 00am :-) Cheers :-) |
|
Still running, uff it takes very long xD 8696 www-data 20 0 621692 84992 31224 R 44,1 1,1 209:39.39 php 210 Minutes :-) Thats strange, maybe my cron job started again or sth like that, because ive started the job at 00am and that is 8hours, not 210minutes... Would be nice if you can implement a check for already generated :-) |
|
@Ramalama2 try The thing is that this app does nothing to fancy. It requests the preview from the preview generator (in the server). If the preview is already there it just gets a reference to a file. You are right that additional checks are required and some extra output would also be nice. |
|
ive tryed pre-generate command, but it runs only a half secound... You mean, that after the time, ive installed the addon, new uploaded images get generated with pre-generate, not that images ive had before the addon in the cloud? then it makes sense :-) |
|
Yeah as long as the app is enabled it will listen to stuff that gets edited. Add it to a list of files to parse. Then when you run |
|
What is the actual purpose of generate-all then? |
|
Rullzer explained at the post above: If you have already previewgenerator installed and you add new photos you make only pre-generate... So generate-all you need in theory only once, for photos uploaded before you installed the addon... Thanks rullzer for your great addon:-) Ps generate-all is still running here, now its running since 450minutes and still consumes 90% of the cpu:-) but i have extremely much photos:-) Will report back after its finished :-) |
|
hmm ok I get that now. |
|
I'm still not understand how to use it. |
|
Thx for the info... So generate-all worked, it runned about 18 hours now, DATAFOLDER/appdata_oc89n0vui9tf/preview/... (3,5 GB) in this folder are thumbnails: ive looked at the pictures they looks good. Now the problem, if i open the gallery in nextcloud, the picture are still getting generated, nothing changed :-((( like the guy above said, the folders are actually all in: so my server worked useless for 18 hours xD At the guy above (Loki3000): I hope this is a simple fix... in the code xD Cheers :-) |
|
PS: please add 400-400.png to your generation too... (thats the gallery overview format) Cheers :-) |
|
@Ramalama2 I can make symlink to every user folder. Access to files controlled by php and every file has unique id. So it's possible as I see. |
|
@Loki3000 Yep, thinked about twice, you have right its possible, as a workaround... better as nothing :-) |
|
@Ramalama2 It's strange but you right: there is no gallery sizes at all. I'm shocked! |
|
So it seems I need to adjust the gallery app. |
|
Thank you so much:-) |
|
Ok I just tested the generate-all function and it seams to work now. I didn't change anything with the app or the php environment. But now it works it is running since 2h and still running without errors. Hope is up. |
|
rullzer, this ones are missing: everything else seems there :-) What about the folders? :-) Cheers :-) |
It's strange: in my gallery base preview size is 200-200.png, 300-200-with-aspect.png and 133-200-with-aspect.png |
|
I have also 267-200-with-aspect.png, 150-200-with-aspect.png and some others.... I rather think it might depends of the original image size, or your screen, or ?..... There must be a logic to adjust the thumbnails size and number for each row on your screen. |
|
Seems I found: Gallery requests thumbs from Where 'scale' depends on browser scale. |
|
@Loki3000 I have a good solution, if @rullzer can add possibility to enter arguments, we can use commands like: so everyone can add his own sizes needed, and the generator generates only that sizes, should be fast... and we can make generate-all / pre-generate to generate the default sizes... Cheers :-) |
|
Not an "end-user" solution... |
|
Please open an issue with the requested sizes to keep the discussion separate. |
Pre generation is by default non end-user solution. @Ramalama2 |
|
I still don't know what causes the error here. As I'm unable to fix it. Altough I'm thinking it might be an invalid image file. Anyway I just merged #31 this kind of mitgates the problem as the next time you run the pre-generate command you will not try the |
|
I think this is fixed in the server now. (So should be fixed in NC12). But I'm not sure. So lets keep it open for now. |
|
I had some problems until some days ago where i just removed the addon and installed it again. Dont know if that makes any difference but now it works again, at least for now. |
|
@mightyBroccoli I did release a new version so maybe a fix was in there that helped solve things a bit. |
|
With Nextcloud 12 there are a lot of hardenings in the server that should help here. Please have a look and open a new issue if it persists. |
|
@rullzer I updated my testing system to 12 beta1. I will update this post in about 12 hours, because the cronjobs runs every 6 hours. |
|
Until this moment i did not get any error messages anymore. |
|
Well it is a combination of both. If some image file is invalid it will of course skip it now. But we have no way to generate previews for it then ;) |
I downloaded and installed your app from the appstore inside NC 11RC1. Everything worked fine even the preview:pre-generate command worked perfectly. I tried the generate-all feature and that was the error message I got.
I am using Nextcloud 11RC1 on a debian mashine with apache2 and php7.0.14 installed.
The text was updated successfully, but these errors were encountered: