Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest release is not the latest #71

Closed
enoch85 opened this issue May 24, 2017 · 6 comments
Closed

The latest release is not the latest #71

enoch85 opened this issue May 24, 2017 · 6 comments
Assignees

Comments

@enoch85
Copy link
Member

enoch85 commented May 24, 2017

In the Nextcloud VM scripts we fetch the latest release with Github API. This means that we currently fecth 1.11.28 when we really should fetch 1.12.28. This causes the script to fail becuase 1.11.28 is not compatible with Nextcloud 12.

Please always release the latest version last. Thanks!

If possible, make a new release that's compatible with Nextcloud 12.

cc @timar

@timar
Copy link
Member

timar commented May 24, 2017

OK, good to know!

@enoch85
Copy link
Member Author

enoch85 commented May 24, 2017

Just as a reference this is the "failing" version command: https://github.com/nextcloud/vm/blob/master/lib.sh#L74

@enoch85
Copy link
Member Author

enoch85 commented May 24, 2017

It chooses the first in the list:

root@cloud:~# curl -s https://api.github.com/repos/nextcloud/richdocuments/releases | grep "tag_name" 
    "tag_name": "1.11.28",
    "tag_name": "1.12.28",
    "tag_name": "1.11.27",
    "tag_name": "1.12.27",
    "tag_name": "1.1.26-nc11",
    "tag_name": "1.1.26",
    "tag_name": "1.1.25",
    "tag_name": "1.1.24",
    "tag_name": "1.1.23",
    "tag_name": "1.1.22",

@enoch85
Copy link
Member Author

enoch85 commented May 24, 2017

@timar Can you please release 1.12.29? But release 1.11.29 first so that 1.12.29 become the "latest release"?

@timar
Copy link
Member

timar commented May 24, 2017

I tried to do what you suggested, but in fact the time of the tag creation counts, not the time of actual release creation. Anyway, now the latest release is 1.12.29, because I removed 1.11.29. Next time I'll make the version 11 tag first.

@timar timar closed this as completed May 24, 2017
@enoch85
Copy link
Member Author

enoch85 commented May 24, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants