Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template renderas empty #10142

Open
rullzer opened this issue Jul 7, 2018 · 5 comments
Open

Add template renderas empty #10142

rullzer opened this issue Jul 7, 2018 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of feature: templates technical debt

Comments

@rullzer
Copy link
Member

rullzer commented Jul 7, 2018

Richdocuments renders all their templates as empty. This is done because we embed the view in an iframe and we do not need the top bar etc etc.

This works because the old code never checks the render as value as being one of the valid ones.

I'd vote to make this an official mode. And then also make sure that we kill javascript that doesn't belong there (for example the search stuff).

CC: @nickvergessen @MorrisJobke

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #5534 (Empty trash), #10128 (Add locale to templates), #9529 (Template file), #74 (Add Automatic Tagging), and #6553 (Add public page template for apps).

@nickvergessen
Copy link
Member

So then there are 3? '', 'blank' and 'empty' ?

I'd vote for "add constants and unify the usage", because f#$k magic strings 😎

@nickvergessen
Copy link
Member

And btw blank and empty are used since 4+ years:

$renderAs = $this->renderAs === 'blank' ? '' : $this->renderAs;

@rullzer
Copy link
Member Author

rullzer commented Jul 9, 2018

Yes lets add them as constants!

Also if they are there already we should exclude some js loading on blank and empty etc.

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 17, 2019
@szaimen
Copy link
Contributor

szaimen commented May 26, 2021

I suppose this issue is still valid? If not, please close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of feature: templates technical debt
Projects
None yet
Development

No branches or pull requests

6 participants