Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageMagick in CI environment to support HEIF/HEIC test cases #10668

Closed
steiny2k opened this issue Aug 13, 2018 · 4 comments
Closed

Update ImageMagick in CI environment to support HEIF/HEIC test cases #10668

steiny2k opened this issue Aug 13, 2018 · 4 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info stale Ticket or PR with no recent activity

Comments

@steiny2k
Copy link
Contributor

Steps to reproduce

  1. Submit a pullrequest like Support HEIC for previews #10526 which requires a recent version of ImageMagick convert tool
  2. CI test case fails: https://drone.nextcloud.com/nextcloud/server/9604

Expected behaviour

Test case should report green.
grafik

Actual behaviour

Due to older version of ImageMagick which lacks support to read HEIF/HEIC files (the new Apple file format for iPhones) in the CI environment, the test case fails (see log below).

Server configuration

Running the tests on macOS with ImageMagick 7.0.8-9 installed through Homebrew works:
brew install --with-libheif imagemagick

Operating system:
macOS 10.13.6

Web server:
embedded php webserver

Database:
embedded sqlite

PHP version:
7.2

Nextcloud version: (see Nextcloud admin page)
github master checkout

Updated from an older Nextcloud/ownCloud or fresh install:
new install

Where did you install Nextcloud from:
github

Signing status:

Signing status
n/a

List of activated apps:

App list
n/a

Nextcloud configuration:

Config report
n/a

Are you using external storage, if yes which one: none

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser:
n/a

Operating system:
n/a

Logs

Web server error log

Web server error log
n/a

Nextcloud log (data/nextcloud.log)

Nextcloud log
1) Test\Preview\HEICTest::testGetThumbnail with data set #0 (-85, -61)
Failed asserting that false is not equal to false.

/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:141
/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:103

2) Test\Preview\HEICTest::testGetThumbnail with data set #1 (34, 26)
Failed asserting that false is not equal to false.

/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:141
/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:103

3) Test\Preview\HEICTest::testGetThumbnail with data set #2 (-76, 55)
Failed asserting that false is not equal to false.

/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:141
/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:103

4) Test\Preview\HEICTest::testGetThumbnail with data set #3 (75, -84)
Failed asserting that false is not equal to false.

/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:141
/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:103

Browser log

Browser log
n/a
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #7406 (Add support for HEIF/HEVC), #4487 (JS tests failing on CI), #6720 (Update jQuery to a supported version), #3161 (Support HHVM), and #2494 (Sqlite support).

@MorrisJobke
Copy link
Member

Let's close this in favor of nextcloud/docker-ci#102

@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jun 12, 2019
@szaimen
Copy link
Contributor

szaimen commented May 21, 2021

I suppose this issue is still valid? If not, please close this issue!

@ghost
Copy link

ghost commented Jun 27, 2021

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label Jun 27, 2021
@ghost ghost closed this as completed Jul 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info stale Ticket or PR with no recent activity
Projects
None yet
Development

No branches or pull requests

5 participants