Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users is not defined when sharing.maxAutocompleteResults is set #10903

Closed
blizzz opened this issue Aug 28, 2018 · 1 comment · Fixed by #11036
Closed

users is not defined when sharing.maxAutocompleteResults is set #10903

blizzz opened this issue Aug 28, 2018 · 1 comment · Fixed by #11036
Assignees
Labels

Comments

@blizzz
Copy link
Member

blizzz commented Aug 28, 2018

Steps to reproduce

  1. add 'sharing.maxAutocompleteResults' => 10, to your config.php
  2. open the share dialog for a file
  3. search for a potential sharee

Expected behaviour

No error

Actual behaviour

ReferenceError: users is not defined[Learn More] sharedialogview.js:410:1

Functionality is not compromised.

In the check in https://github.com/nextcloud/server/blob/master/core/js/sharedialogview.js#L406 the users variable (and following) are not set, after some restructuring.

This could be replaced by suggestions, but we cannot get just the length as we need to use it seperately per shareType.

Perhaps best to estimate the max value on _getSuggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants