Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all apps after/during running the upgrader with occ #11102

Closed
enoch85 opened this issue Sep 7, 2018 · 24 comments
Closed

Upgrade all apps after/during running the upgrader with occ #11102

enoch85 opened this issue Sep 7, 2018 · 24 comments
Assignees

Comments

@enoch85
Copy link
Member

enoch85 commented Sep 7, 2018

Upgraded to NC 14 today and about 20 apps where deactivated due to that they where "incompatible". I then had to go to the App Store and manually re-enable them. In 13.0.6 I didn't have to as the option--no--app-disable could be used, and the apps where upgraded automatically. Why did you remove that?

Please upgrade all apps before running the upgrade of all the rest when running with the occ command, or please add back the --no-app-disable

Thanks!

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #10918 (Occ Upgrade forces to run once a day), #6960 (occ upgrade is outdated), #10954 (OCC upgrade throws unhandled exception), #8092 (Upgrade notice should not be displayed when occ is run with --output=json), and #10949 ([WORKAROUND] NC14 RC2: occ upgrade hangs on running cronjob it states).

@JSoko
Copy link
Member

JSoko commented Sep 7, 2018

about 20 apps where deactivated due to that they where "incompatible". I then had to go to the App Store and manually re-enable them

Had the same issue too...
...while updating from 13.0.6 to 14.0.0.19

@jospoortvliet
Copy link
Member

Should be fixed with 14.0.1, pls test.

@JSoko
Copy link
Member

JSoko commented Sep 26, 2018

Same here while upgrading from 14.0.0.19 to 14.0.1.1. Had to reactivate the apps manualy.

Have to say that I used the updatescript from @enoch85...

Disabled incompatible app: announcementcenter
Disabled incompatible app: apporder
Disabled incompatible app: bookmarks
Disabled incompatible app: calendar
Disabled incompatible app: caniupdate
Disabled incompatible app: contacts
Disabled incompatible app: data_request
Disabled incompatible app: deck
Disabled incompatible app: external
Disabled incompatible app: files_downloadactivity
Disabled incompatible app: files_linkeditor
Disabled incompatible app: files_rightclick
Disabled incompatible app: impersonate
Disabled incompatible app: issuetemplate
Disabled incompatible app: mindmaps
Disabled incompatible app: news
Disabled incompatible app: notes
Disabled incompatible app: ocsms
Disabled incompatible app: ownbackup
Disabled incompatible app: piwik
Disabled incompatible app: polls
Disabled incompatible app: previewgenerator
Disabled incompatible app: quota_warning
Disabled incompatible app: radio
Disabled incompatible app: ransomware_detection
Disabled incompatible app: sharerenamer
Disabled incompatible app: socialsharing_email
Disabled incompatible app: spreed
Disabled incompatible app: tasks
Disabled incompatible app: telephoneprovider
Disabled incompatible app: user_usage_report
Disabled incompatible app: w2g2

https://github.com/nextcloud/vm/blob/master/nextcloud_update.sh

@enoch85
Copy link
Member Author

enoch85 commented Sep 26, 2018

Should be fixed with 14.0.1, pls test.

@jospoortvliet Is a trigger needed like in NC 13 or is it done automatically?

@JSoko The update script in the VM does a occ upgrade so no difference from the GUI updater.

@JSoko
Copy link
Member

JSoko commented Sep 27, 2018

so no difference from the GUI updater.
Yes, but I wanted to state that we both have a simular situation...

@mjanssens
Copy link
Contributor

Same symptoms here.
I have tested the following manual upgrades:
13.0.6 -> 14.0.0
14.0.0 -> 14.0.1
14.0.1 -> 14.0.2 RC1
All have same result as mentioned in bug report.
Using files from official NC downloaded packages.
When following step 8 from https://docs.nextcloud.com/server/14/admin_manual/maintenance/manual_upgrade.html all packages get upgraded nicely.
Apparently I never executed this step.
Maybe I'm overlooking but I can't detect this step either in https://github.com/nextcloud/vm/blob/master/nextcloud_update.sh

It seems that this behavior has changed since NC14.
I tested a manual upgrade from 13.0.5 -> 13.0.6
All packages are upgraded without executing step 8. So apparently in NC13 the 3rd party packages such as News and twofactor_totp are upgraded without their folders being present in the apps folder.

I'm wondering now if the documentation in step 8 is still valid and which of the following procedures is correct:

  1. following step 8, copying the missing folders
  2. just let the apps get disabled during upgrade, after the upgrade download/enable them from the store (the upgrade log displays exactly which apps were disabled).
  3. something different ;-)

@enoch85
Copy link
Member Author

enoch85 commented Oct 7, 2018

Maybe I'm overlooking but I can't detect this step either in https://github.com/nextcloud/vm/blob/master/nextcloud_update.sh

Before NC14 we used --no-app-disable which won't work in NC 14 anymore so we removed it.
Before like NC12 or something we used a python script to automatically copy back all the disabled apps. The downside with that is that if the app isn't compatible. the upgrade will fail.

So adding back --no-app-disable or update 3rd-party pass by default in core would be a fix, but sadly the first one is removed, and our fix may break the upgrade process.

@enoch85
Copy link
Member Author

enoch85 commented Oct 12, 2018

@jospoortvliet

Should be fixed with 14.0.1, pls test.

Nope, it's not fixed. This is 14.0.1 --> 14.0.3:

root@nextcloudintern:~# sudo -u www-data php /var/www/nextcloud/occ upgrade -h
Usage:
  upgrade

Options:
  -h, --help            Display this help message
  -q, --quiet           Do not output any message
  -V, --version         Display this application version
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Do not ask any interactive question
      --no-warnings     Skip global warnings, show command output only
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

Help:
  run upgrade routines after installation of a new release. The release has to be installed before.

@jospoortvliet
Copy link
Member

The thing that is fixed is that the app store had incompatible apps still. Only those get disabled, not compatible apps.

Try to upgrade now, you should not have any app disable unless they actually ARE incompatible. And if they are you should see that before you upgrade in the upgrade screen.

@enoch85
Copy link
Member Author

enoch85 commented Oct 16, 2018

@jospoortvliet That doesn't explain why occ app:install works directly after the upgrade was made.

If the apps were incompatible then occ app:install wouldn't install them. Or am I missing something here?

Example of apps that gets disabled:

  • Contacts
  • Calendar
  • Collabora (richdocuments)
  • All of the Full Text Search apps

Tried again today from 14.0.1 --> 14.0.3 still same behavior.

@enoch85
Copy link
Member Author

enoch85 commented Oct 16, 2018

https://www.youtube.com/watch?v=cPr8EPxWda0

screenshot from 2018-10-16 16-40-58

Added with occ app:install

screenshot from 2018-10-16 16-47-49

14.0.1 -- 14.0.3.

So this should be labeled bug instead?

cc @MorrisJobke

@enoch85
Copy link
Member Author

enoch85 commented Oct 16, 2018

@MorrisJobke MorrisJobke reopened this Oct 16, 2018
@enoch85 enoch85 changed the title Upgrade all apps before running the upgrader with occ Upgrade all apps after/during running the upgrader with occ Oct 16, 2018
@enoch85
Copy link
Member Author

enoch85 commented Oct 19, 2018

I see this everywhere... nextcloud/fulltextsearch#395 (comment)

In order to be able to use NC 14.0.3.0, the apps must be deactivated beforehand. Then do the NC Upadte and then reactivate the apps.

So to update all apps they need to be disabled first?

@MorrisJobke
Copy link
Member

So to update all apps they need to be disabled first?

Usually not. Where was it written, that it needs to be like that?

Is this the case if the old app is not compatible with 14 and the new app not compatible with 13? cc @nickvergessen @rullzer

@rullzer
Copy link
Member

rullzer commented Oct 23, 2018

Could be. I'm not sure to be honest.

@ChristophWurst
Copy link
Member

Just ran into the the very same issue (I think). Updated my instance from 14.0.2 to 15 RC1. Got

Disabled incompatible app: calendar
Disabled incompatible app: contacts
Disabled incompatible app: deck
Disabled incompatible app: twofactor_totp
Disabled incompatible app: twofactor_u2f

In contrast to the apps that were still compatible, these were not updated. I had to update them manually and re-enable.

@ChristophWurst
Copy link
Member

In contrast to the apps that were still compatible, these were not updated. I had to update them manually and re-enable.

Ref #8380 cc @nickvergessen

@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Nov 30, 2018
@loxK
Copy link

loxK commented May 7, 2019

I have this exact issue after upgrading to 16.0.0 with the web upgrader. Some critical app like calendar are not activated nor upgraded

@loxK
Copy link

loxK commented May 7, 2019

How can I force apps upgrade?

@enoch85
Copy link
Member Author

enoch85 commented May 8, 2019

@loxK In the Nextcloud VM we use occ: https://github.com/nextcloud/vm/blob/master/nextcloud_update.sh#L210 + this script to reinstall all the disabled apps again: https://github.com/nextcloud/vm/blob/master/static/recover_apps.py

The recover script only works on the VM though, it's not default.

@rullzer rullzer modified the milestones: Nextcloud 17.0.4, Nextcloud 17.0.5 Mar 11, 2020
@rullzer rullzer modified the milestones: Nextcloud 17.0.5, Nextcloud 17.0.6 Mar 23, 2020
@enoch85 enoch85 closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants