Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure federated sharing accepts @user@cloud.example.com usernames #12776

Closed
jancborchardt opened this issue Dec 2, 2018 · 4 comments
Closed
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: federation feature: sharing needs info

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Dec 2, 2018

As services like Mastodon and other ActivityPub-enabled software uses an ID like @user@cloud.example.com, we should make sure that our federated sharing also accepts that everywhere to avoid confusion:

  • Share link page in top right "Add to your Nextcloud"
  • Sharing sidebar when sharing with others
  • elsewhere?

The only difference between our "Federated Cloud ID" and the ActivityPub username seems to be the prepended @ before the username.

cc @schiessle @MorrisJobke @rullzer @juliushaertl @daita – not sure how big of a fix is this, but likely a backport to 15 would be good.

@MorrisJobke
Copy link
Member

I guess nothing for 15.0.0

@skjnldsv
Copy link
Member

IS this still an issue?

@jancborchardt
Copy link
Member Author

Just tested (and you can do so too ;) and this is still exactly the same issue, in the places as described above.

@szaimen
Copy link
Contributor

szaimen commented Jan 9, 2023

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2023
@szaimen szaimen closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: federation feature: sharing needs info
Projects
None yet
Development

No branches or pull requests

5 participants