OCSExption "Cannot remove yourself from the admin group" is not translatable

[rakekniven]

Reported at forums.

See https://help.nextcloud.com/t/die-deutsche-ubersetzung-von-nextcloud-hier-diskutieren-und-fehler-melden/32139/120

Source line:

server/apps/provisioning_api/lib/Controller/UsersController.php

Line 751 in b8b650a

throw new OCSException('Cannot remove yourself from the admin group', 105);

[rakekniven]

Same for another one: "Bad request"

server/apps/provisioning_api/lib/Controller/UsersController.php

Line 333 in b8b650a

throw new OCSException('Bad request', 101);

Should I file separate issue?

[skjnldsv]

The api messages should not be translated I think.
@rullzer @blizzz @nickvergessen ?

[nickvergessen]

Well, we could turn it into a hintexception and then have english+translated.
But not sure that breaks assumptions on the API users.

[rakekniven]

The text is visible to the user so it should be translated IMHO.

[skjnldsv]

@rakekniven where did you saw the message? Users management?

[rakekniven]

Forum is back online.
See link from initial post:

https://help.nextcloud.com/t/die-deutsche-ubersetzung-von-nextcloud-hier-diskutieren-und-fehler-melden-was-sollte-ich-wissen-wenn-ich-bei-der-ubersetzung-helfen-mochte-oder-eine-anmerkung-habe/32139/118

[skjnldsv]

Ah yes, I recall now. We're indeed using the error message as a notification.
Shall we translate the error message or use a matching code on the request on the users management and translate it from there?

[szaimen]

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

[rakekniven]

Still an issue at v25.0.2.

[susnux]

I would say we should translate the message as you should rather rely on the exception code for any programmatically usage. Translating in the frontend seems to duplicate logic / code.

[rakekniven]

Wow, I four year old issue got an reply 😄 .

Just tested and issue is still there with NC v28.0.1