Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show note to recipient on shares more prominent #13874

Open
bpcurse opened this issue Jan 28, 2019 · 8 comments
Open

Show note to recipient on shares more prominent #13874

bpcurse opened this issue Jan 28, 2019 · 8 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@bpcurse
Copy link

bpcurse commented Jan 28, 2019

Is your feature request related to a problem? Please describe.
If a note on shared content is important, the actual way to display it as a small bubble on the top right is not sufficient. Most people opening the share link probably won't even notice it is there.

Describe the solution you'd like
The note could be displayed in a way similar to the first run wizard. Ideally the user who shares the link can choose between the actual way (small bubble) and the forced display e.g. with a checkbox "force display".

@bpcurse bpcurse added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Jan 28, 2019
@MorrisJobke
Copy link
Member

cc @nextcloud/designers

@ariko861
Copy link

A javascript popup window could appear once the page has loaded. This could be set as an option in the sharing options.

@skjnldsv
Copy link
Member

@jancborchardt why not use the same design as the readme header thing? :)

@jancborchardt
Copy link
Member

jancborchardt commented Dec 30, 2019

@jancborchardt why not use the same design as the readme header thing? :)

Yup, good point, that’s much more obvious and reusable. :) Let’s do that. 👍

If someone points out where this has to be edited, this would be a nice good first issue.

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of good first issue Small tasks with clear documentation about how and in which place you need to fix things in. and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 30, 2019
@juliushaertl
Copy link
Member

The current note button/popover is registered here. It needs to be replaced with a plugin to the file list that registers a header section as done in the text app: https://github.com/nextcloud/text/blob/master/src/helpers/files.js#L158-L199

@alexbijma
Copy link

may'be the rich workspace could be used for this, viewing it readonly?

@juliushaertl
Copy link
Member

Rich workspace won't work here since the file would be the same readme.md for all shares while the note can be different on each share link.

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of and removed 1. to develop Accepted and waiting to be taken care of labels May 27, 2021
@Practicalbutterfly5
Copy link

Hello, is this feature still in development?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

9 participants