Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File delete hooks on user deletion hook #14004

Open
stalker314314 opened this issue Feb 3, 2019 · 0 comments
Open

File delete hooks on user deletion hook #14004

stalker314314 opened this issue Feb 3, 2019 · 0 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: users and groups good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@stalker314314
Copy link
Contributor

Nextcloud have (pre|post)Delete hooks for both files and users. However, when user is deleted, all its files are gone too, but apps do not receive file delete hook, just user delete hooks. If app is dealing with user's files and keeping them internally and need to delete internal records when file is removed (basically - any app that subscribes to postDelete file hook) will end up with rows that cannot be cleaned up once user is deleted. Impact is that internal state (database) is getting bigger, and app developer need to hook into postDelete user and handle deleting bunch of files from another hook.

Repro:

  • Create user
  • Create bunch of files for that user
  • Observe bunch of postCreate file hooks
  • Delete user
  • Observe lack of postDelete file hooks

Maybe this is a bug (should work, but it is not working), maybe this is request for a feature, maybe a 'by-design' (you like it this way and do not plan to change it).

@stalker314314 stalker314314 added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 3, 2019
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of good first issue Small tasks with clear documentation about how and in which place you need to fix things in. feature: users and groups and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: users and groups good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

2 participants