Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test apps against PHP 7.4 #18146

Closed
27 tasks done
nickvergessen opened this issue Nov 28, 2019 · 15 comments
Closed
27 tasks done

Test apps against PHP 7.4 #18146

nickvergessen opened this issue Nov 28, 2019 · 15 comments
Assignees
Labels
3. to review Waiting for reviews bug

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Nov 28, 2019

@nickvergessen nickvergessen added bug 2. developing Work in progress labels Nov 28, 2019
@nickvergessen nickvergessen self-assigned this Nov 28, 2019
@tigernero79
Copy link

debsury.org has just tweeted the availability of php 7.4 in their repositories for both Debian and Ubuntu and their derivatives. concluding that it can redis and memcache will be available for the weekend .. the tests could start I believe.

URL: https://twitter.com/debsuryorg/status/1200134300924035072?s=19

@nursoda
Copy link

nursoda commented Nov 30, 2019

PHP and PHP-FPM 7.4 were released for Arch yesterday, so there are users that do update PHP via pacman now but are hit by self-installed (non-repo) Nextcloud being compatible. For the Arch Nextcloud package, a dependency bug already exists. Please start tests and ideally mark 17.0.2 compatible for PHP 7.4.

@ChristophWurst
Copy link
Member

Paused because 7.4 is still not available on travis

Not the final, but a snapshot: https://github.com/nextcloud/mail/blob/e2b2d14cff218e0cd4e70755c0645d89ba47bf0f/.travis.yml#L7

@gary-kim
Copy link
Member

gary-kim commented Dec 4, 2019

It looks like 7.4 is now officially available on Travis

@nickvergessen
Copy link
Member Author

Yeah, will do all the "fun" tomorrow

@nickvergessen
Copy link
Member Author

Unluckily sqlite3 seems to not have the php package installed:
https://travis-ci.org/nextcloud/announcementcenter/builds/618121250

@NeroBurner
Copy link

or rather travis-ci does not yet supply the php 7.4 tar file. Where would be the place to let travis know this is missing?

7.4 is not pre-installed; installing
Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/php/binaries/ubuntu/16.04/x86_64/php-7.4.tar.bz2
$ curl -sSf --retry 5 -o archive.tar.bz2 $archive_url && tar xjf archive.tar.bz2 --directory /
curl: (22) The requested URL returned error: 404 Not Found

@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2019
@nickvergessen
Copy link
Member Author

List above is ready to review now with 7.4snapshot

@Lucavon
Copy link

Lucavon commented Dec 7, 2019

Any ETA as to when this will be on the Beta channel?

@yverry
Copy link
Contributor

yverry commented Dec 8, 2019

18 is on beta channel

@J0WI
Copy link
Contributor

J0WI commented Jan 10, 2020

This should probably be reviewed before the release and documented in https://docs.nextcloud.com/server/18/admin_manual/installation/source_installation.html

@nickvergessen
Copy link
Member Author

Merged the remaining PRs to be able to proceed

@NeroBurner
Copy link

does this mean v18.0.0 https://github.com/nextcloud/server/releases/tag/v18.0.0 is ready for PHP 7.4?

@ChristophWurst
Copy link
Member

yes

@nursoda
Copy link

nursoda commented Jan 20, 2020

What does that mean in respect to the app impersonate which is in the above list? Just that it can be used with PHP 7.4, right? (It does NOT work in NC18.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

No branches or pull requests

9 participants