Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LDAP] Sabre\VObject\ParseException: This parser only supports VCARD and VCALENDAR files #22460

Closed
Zoddo opened this issue Aug 27, 2020 · 4 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info

Comments

@Zoddo
Copy link

Zoddo commented Aug 27, 2020

How to use GitHub

  • Please use the 馃憤 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Try to share a file
  2. Search a user

Expected behaviour

The user is found, if it exists

Actual behaviour

The search is running indefinitely according to the UI:
image

In the browser's dev tools, we can see the result of the request to /ocs/v1.php/apps/files_sharing/api/v1/sharees:

{"ocs":{"meta":{"status":"failure","statuscode":998,"message":"Invalid query, please check the syntax. API specifications are here: http:\/\/www.freedesktop.org\/wiki\/Specifications\/open-collaboration-services.\n"},"data":[]}}

Checking data/nextcloud.log, this error is logged:

Reformatted json
{
   "reqId":"BhSKbmak7Fhcxt3RCkrq",
   "level":3,
   "time":"2020-08-27T15:50:51+01:00",
   "remoteAddr":"[REDACTED]",
   "user":"[REDACTED]",
   "app":"no app in context",
   "method":"GET",
   "url":"/ocs/v1.php/apps/files_sharing/api/v1/sharees?format=json&itemType=file&search=[REDACTED]&lookup=false&perPage=200&shareType[]=0&shareType[]=1&shareType[]=6&shareType[]=9&shareType[]=7&shareType[]=10&shareType[]=8&shareType[]=4",
   "message":{
      "Exception":"Sabre\\VObject\\ParseException",
      "Message":"This parser only supports VCARD and VCALENDAR files",
      "Code":0,
      "Trace":[
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/vobject/lib/Parser/MimeDir.php",
            "line":90,
            "function":"parseDocument",
            "class":"Sabre\\VObject\\Parser\\MimeDir",
            "type":"->",
            "args":[
               
            ]
         },
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/vobject/lib/Reader.php",
            "line":47,
            "function":"parse",
            "class":"Sabre\\VObject\\Parser\\MimeDir",
            "type":"->",
            "args":[
               "Resource id #469",
               0
            ]
         },
         {
            "file":"/var/www/nextcloud/apps/dav/lib/CardDAV/AddressBookImpl.php",
            "line":204,
            "function":"read",
            "class":"Sabre\\VObject\\Reader",
            "type":"::",
            "args":[
               "Resource id #469"
            ]
         },
         {
            "file":"/var/www/nextcloud/apps/dav/lib/CardDAV/AddressBookImpl.php",
            "line":125,
            "function":"readCard",
            "class":"OCA\\DAV\\CardDAV\\AddressBookImpl",
            "type":"->",
            "args":[
               "Resource id #469"
            ]
         },
         {
            "file":"/var/www/nextcloud/lib/private/ContactsManager.php",
            "line":52,
            "function":"search",
            "class":"OCA\\DAV\\CardDAV\\AddressBookImpl",
            "type":"->",
            "args":[
               "[REDACTED]@[REDACTED].com",
               [
                  "EMAIL",
                  "FN"
               ],
               {
                  "limit":200,
                  "offset":0
               }
            ]
         },
         {
            "file":"/var/www/nextcloud/lib/private/Collaboration/Collaborators/MailPlugin.php",
            "line":85,
            "function":"search",
            "class":"OC\\ContactsManager",
            "type":"->",
            "args":[
               "[REDACTED]@[REDACTED].com",
               [
                  "EMAIL",
                  "FN"
               ],
               {
                  "limit":200,
                  "offset":0
               }
            ]
         },
         {
            "file":"/var/www/nextcloud/lib/private/Collaboration/Collaborators/Search.php",
            "line":70,
            "function":"search",
            "class":"OC\\Collaboration\\Collaborators\\MailPlugin",
            "type":"->",
            "args":[
               "[REDACTED]@[REDACTED].com",
               200,
               0,
               {
                  "__class__":"OC\\Collaboration\\Collaborators\\SearchResult"
               }
            ]
         },
         {
            "file":"/var/www/nextcloud/apps/files_sharing/lib/Controller/ShareesAPIController.php",
            "line":213,
            "function":"search",
            "class":"OC\\Collaboration\\Collaborators\\Search",
            "type":"->",
            "args":[
               "[REDACTED]@[REDACTED].com",
               [
                  0,
                  1,
                  4,
                  6,
                  9
               ],
               false,
               200,
               0
            ]
         },
         {
            "file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
            "line":170,
            "function":"search",
            "class":"OCA\\Files_Sharing\\Controller\\ShareesAPIController",
            "type":"->",
            "args":[
               "[REDACTED]@[REDACTED].com",
               "file",
               1,
               200,
               [
                  "0",
                  "1",
                  "6",
                  "9",
                  "7",
                  "10",
                  "8",
                  "4"
               ],
               false
            ]
         },
         {
            "file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
            "line":100,
            "function":"executeController",
            "class":"OC\\AppFramework\\Http\\Dispatcher",
            "type":"->",
            "args":[
               {
                  "__class__":"OCA\\Files_Sharing\\Controller\\ShareesAPIController"
               },
               "search"
            ]
         },
         {
            "file":"/var/www/nextcloud/lib/private/AppFramework/App.php",
            "line":137,
            "function":"dispatch",
            "class":"OC\\AppFramework\\Http\\Dispatcher",
            "type":"->",
            "args":[
               {
                  "__class__":"OCA\\Files_Sharing\\Controller\\ShareesAPIController"
               },
               "search"
            ]
         },
         {
            "file":"/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php",
            "line":47,
            "function":"main",
            "class":"OC\\AppFramework\\App",
            "type":"::",
            "args":[
               "OCA\\Files_Sharing\\Controller\\ShareesAPIController",
               "search",
               {
                  "__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"
               },
               {
                  "_route":"ocs.files_sharing.ShareesAPI.search"
               }
            ]
         },
         {
            "function":"__invoke",
            "class":"OC\\AppFramework\\Routing\\RouteActionHandler",
            "type":"->",
            "args":[
               {
                  "_route":"ocs.files_sharing.ShareesAPI.search"
               }
            ]
         },
         {
            "file":"/var/www/nextcloud/lib/private/Route/Router.php",
            "line":297,
            "function":"call_user_func",
            "args":[
               {
                  "__class__":"OC\\AppFramework\\Routing\\RouteActionHandler"
               },
               {
                  "_route":"ocs.files_sharing.ShareesAPI.search"
               }
            ]
         },
         {
            "file":"/var/www/nextcloud/ocs/v1.php",
            "line":88,
            "function":"match",
            "class":"OC\\Route\\Router",
            "type":"->",
            "args":[
               "/ocsapp/apps/files_sharing/api/v1/sharees"
            ]
         }
      ],
      "File":"/var/www/nextcloud/3rdparty/sabre/vobject/lib/Parser/MimeDir.php",
      "Line":163,
      "CustomMessage":"--"
   },
   "userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36",
   "version":"19.0.2.2"
}

Upon further investigation, we found that this issue happens when at least one LDAP user is matching the search.
If no users (or only local users) match the search terms, the request will be processed without issues.

Server configuration

Operating system: Debian 10

Web server: Apache 2.4

Database: MariaDB 10.3

PHP version: PHP 7.3

Nextcloud version: 19.0.2

Updated from an older Nextcloud/ownCloud or fresh install: Upgraded from a very old OwnCloud install

Where did you install Nextcloud from: From source

Signing status:

Signing status
No errors have been found.

List of activated apps:

App list
Enabled:
  - accessibility: 1.5.0
  - activity: 2.12.0
  - admin_audit: 1.9.0
  - announcementcenter: 3.8.1
  - bruteforcesettings: 1.6.0
  - cloud_federation_api: 1.2.0
  - comments: 1.9.0
  - contactsinteraction: 1.0.0
  - dav: 1.15.0
  - federatedfilesharing: 1.9.0
  - files: 1.14.0
  - files_automatedtagging: 1.9.0
  - files_downloadactivity: 1.8.0
  - files_lock: 0.8.3
  - files_pdfviewer: 1.8.0
  - files_retention: 1.8.2
  - files_rightclick: 0.16.0
  - files_sharing: 1.11.0
  - files_trashbin: 1.9.0
  - files_versions: 1.12.0
  - files_videoplayer: 1.8.0
  - groupfolders: 7.0.0
  - keeweb: 0.6.2
  - logreader: 2.4.0
  - lookup_server_connector: 1.7.0
  - metadata: 0.12.0
  - nextcloud_announcements: 1.8.0
  - notifications: 2.7.0
  - oauth2: 1.7.0
  - password_policy: 1.9.1
  - photos: 1.1.0
  - privacy: 1.3.0
  - provisioning_api: 1.9.0
  - quota_warning: 1.8.0
  - ransomware_protection: 1.7.0
  - recommendations: 0.7.0
  - serverinfo: 1.9.0
  - settings: 1.1.0
  - sharebymail: 1.9.0
  - socialsharing_email: 2.1.0
  - support: 1.2.1
  - survey_client: 1.7.0
  - systemtags: 1.9.0
  - text: 3.0.1
  - theming: 1.10.0
  - twofactor_admin: 3.0.0
  - twofactor_backupcodes: 1.8.0
  - twofactor_nextcloud_notification: 2.3.0
  - twofactor_totp: 5.0.0
  - twofactor_u2f: 6.0.0
  - unsplash: 1.1.6
  - updatenotification: 1.9.0
  - user_ldap: 1.9.0
  - viewer: 1.3.0
  - workflowengine: 2.1.0
Disabled:
  - encryption
  - federation
  - files_external
  - firstrunwizard
  - mail
  - passwords
  - twofactor_email
  - twofactor_webauthn
  - user_saml

Nextcloud configuration:

Config report
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.[REDACTED].com",
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/cloud.[REDACTED].com\/",
        "htaccess.RewriteBase": "\/",
        "dbtype": "mysql",
        "version": "19.0.2.2",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "logtimezone": "CET",
        "installed": true,
        "ldapIgnoreNamingRules": false,
        "forcessl": true,
        "forceSSLforSubdomains": true,
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "theme": "gruautheme_v2",
        "maintenance": false,
        "loglevel": "3",
        "trashbin_retention_obligation": "1",
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
        "mysql.utf8mb4": true,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "updater.release.channel": "stable",
        "app_install_overwrite": [
            "twofactor_email",
            "twofactor_webauthn",
            "keeweb"
        ]
    }
}

Are you using external storage, if yes which one: No

Are you using encryption: No

Are you using an external user-backend, if yes which one: LDAP (ActiveDirectory)

LDAP configuration (delete this part if not used)

LDAP config
+-------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Configuration                 |                                                                                                                                                                                                                            |
+-------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| hasMemberOfFilterSupport      | 1                                                                                                                                                                                                                          |
| homeFolderNamingRule          |                                                                                                                                                                                                                            |
| lastJpegPhotoLookup           | 0                                                                                                                                                                                                                          |
| ldapAgentName                 | CN=authLDAP,[REDACTED],DC=net                                                                                                                                                                                              |
| ldapAgentPassword             | ***                                                                                                                                                                                                                        |
| ldapAttributesForGroupSearch  |                                                                                                                                                                                                                            |
| ldapAttributesForUserSearch   |                                                                                                                                                                                                                            |
| ldapBackupHost                |                                                                                                                                                                                                                            |
| ldapBackupPort                |                                                                                                                                                                                                                            |
| ldapBase                      | DC=[REDACTED],DC=net                                                                                                                                                                                                       |
| ldapBaseGroups                | DC=[REDACTED],DC=net                                                                                                                                                                                                       |
| ldapBaseUsers                 | DC=[REDACTED],DC=net                                                                                                                                                                                                       |
| ldapCacheTTL                  | 600                                                                                                                                                                                                                        |
| ldapConfigurationActive       | 1                                                                                                                                                                                                                          |
| ldapDefaultPPolicyDN          |                                                                                                                                                                                                                            |
| ldapDynamicGroupMemberURL     |                                                                                                                                                                                                                            |
| ldapEmailAttribute            | mail                                                                                                                                                                                                                       |
| ldapExperiencedAdmin          | 0                                                                                                                                                                                                                          |
| ldapExpertUUIDGroupAttr       |                                                                                                                                                                                                                            |
| ldapExpertUUIDUserAttr        | sAMAccountName                                                                                                                                                                                                             |
| ldapExpertUsernameAttr        | sAMAccountName                                                                                                                                                                                                             |
| ldapExtStorageHomeAttribute   |                                                                                                                                                                                                                            |
| ldapGidNumber                 | gidNumber                                                                                                                                                                                                                  |
| ldapGroupDisplayName          | cn                                                                                                                                                                                                                         |
| ldapGroupFilter               | (&(|(objectclass=group))(|(cn=APP_Owncloud)))                                                                                                                                                                              |
| ldapGroupFilterGroups         | APP_Owncloud                                                                                                                                                                                                               |
| ldapGroupFilterMode           | 0                                                                                                                                                                                                                          |
| ldapGroupFilterObjectclass    | group                                                                                                                                                                                                                      |
| ldapGroupMemberAssocAttr      | member                                                                                                                                                                                                                     |
| ldapHost                      | [REDACTED]                                                                                                                                                                                                                 |
| ldapIgnoreNamingRules         |                                                                                                                                                                                                                            |
| ldapLoginFilter               | (&(&(|(objectclass=person)(objectclass=user))(|(|(memberof=CN=APP_Owncloud,[REDACTED],DC=net)(primaryGroupID=20672))))(|(samaccountname=%uid)(|(mailPrimaryAddress=%uid)(mail=%uid))))                                     |
| ldapLoginFilterAttributes     |                                                                                                                                                                                                                            |
| ldapLoginFilterEmail          | 1                                                                                                                                                                                                                          |
| ldapLoginFilterMode           | 0                                                                                                                                                                                                                          |
| ldapLoginFilterUsername       | 1                                                                                                                                                                                                                          |
| ldapMatchingRuleInChainState  | available                                                                                                                                                                                                                  |
| ldapNestedGroups              | 1                                                                                                                                                                                                                          |
| ldapOverrideMainServer        |                                                                                                                                                                                                                            |
| ldapPagingSize                | 500                                                                                                                                                                                                                        |
| ldapPort                      | 389                                                                                                                                                                                                                        |
| ldapQuotaAttribute            |                                                                                                                                                                                                                            |
| ldapQuotaDefault              |                                                                                                                                                                                                                            |
| ldapTLS                       | 0                                                                                                                                                                                                                          |
| ldapUserAvatarRule            | default                                                                                                                                                                                                                    |
| ldapUserDisplayName           | cn                                                                                                                                                                                                                         |
| ldapUserDisplayName2          |                                                                                                                                                                                                                            |
| ldapUserFilter                | (&(|(objectclass=person)(objectclass=user))(|(|(memberof=CN=APP_Owncloud,[REDACTED],DC=net)(primaryGroupID=20672))))                                                                                                       |
| ldapUserFilterGroups          | APP_Owncloud                                                                                                                                                                                                               |
| ldapUserFilterMode            | 0                                                                                                                                                                                                                          |
| ldapUserFilterObjectclass     | person;user                                                                                                                                                                                                                |
| ldapUuidGroupAttribute        | auto                                                                                                                                                                                                                       |
| ldapUuidUserAttribute         | auto                                                                                                                                                                                                                       |
| turnOffCertCheck              | 0                                                                                                                                                                                                                          |
| turnOnPasswordChange          | 0                                                                                                                                                                                                                          |
| useMemberOfToDetectMembership | 1                                                                                                                                                                                                                          |
+-------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
+-------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Configuration                 | s01                                                                                                                                                                                                                        |
+-------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| hasMemberOfFilterSupport      | 1                                                                                                                                                                                                                          |
| homeFolderNamingRule          |                                                                                                                                                                                                                            |
| lastJpegPhotoLookup           | 0                                                                                                                                                                                                                          |
| ldapAgentName                 | CN=authLDAP,[REDACTED],DC=net                                                                                                                                                                                              |
| ldapAgentPassword             | ***                                                                                                                                                                                                                        |
| ldapAttributesForGroupSearch  |                                                                                                                                                                                                                            |
| ldapAttributesForUserSearch   |                                                                                                                                                                                                                            |
| ldapBackupHost                |                                                                                                                                                                                                                            |
| ldapBackupPort                |                                                                                                                                                                                                                            |
| ldapBase                      | DC=[REDACTED],DC=net                                                                                                                                                                                                       |
| ldapBaseGroups                | DC=[REDACTED],DC=net                                                                                                                                                                                                       |
| ldapBaseUsers                 | DC=[REDACTED],DC=net                                                                                                                                                                                                       |
| ldapCacheTTL                  | 600                                                                                                                                                                                                                        |
| ldapConfigurationActive       | 1                                                                                                                                                                                                                          |
| ldapDefaultPPolicyDN          |                                                                                                                                                                                                                            |
| ldapDynamicGroupMemberURL     |                                                                                                                                                                                                                            |
| ldapEmailAttribute            | mail                                                                                                                                                                                                                       |
| ldapExperiencedAdmin          | 0                                                                                                                                                                                                                          |
| ldapExpertUUIDGroupAttr       |                                                                                                                                                                                                                            |
| ldapExpertUUIDUserAttr        | sAMAccountName                                                                                                                                                                                                             |
| ldapExpertUsernameAttr        | sAMAccountName                                                                                                                                                                                                             |
| ldapExtStorageHomeAttribute   |                                                                                                                                                                                                                            |
| ldapGidNumber                 | gidNumber                                                                                                                                                                                                                  |
| ldapGroupDisplayName          | cn                                                                                                                                                                                                                         |
| ldapGroupFilter               | (&(|(objectclass=group))(|(cn=APP_Owncloud)))                                                                                                                                                                              |
| ldapGroupFilterGroups         | APP_Owncloud                                                                                                                                                                                                               |
| ldapGroupFilterMode           | 0                                                                                                                                                                                                                          |
| ldapGroupFilterObjectclass    | group                                                                                                                                                                                                                      |
| ldapGroupMemberAssocAttr      | member                                                                                                                                                                                                                     |
| ldapHost                      | [REDACTED]                                                                                                                                                                                                                 |
| ldapIgnoreNamingRules         |                                                                                                                                                                                                                            |
| ldapLoginFilter               | (&(&(|(objectclass=person)(objectclass=user))(|(|(memberof=CN=APP_Owncloud,[REDACTED],DC=net)(primaryGroupID=20672))))(|(samaccountname=%uid)(|(mailPrimaryAddress=%uid)(mail=%uid))))                                     |
| ldapLoginFilterAttributes     |                                                                                                                                                                                                                            |
| ldapLoginFilterEmail          | 1                                                                                                                                                                                                                          |
| ldapLoginFilterMode           | 0                                                                                                                                                                                                                          |
| ldapLoginFilterUsername       | 1                                                                                                                                                                                                                          |
| ldapMatchingRuleInChainState  | available                                                                                                                                                                                                                  |
| ldapNestedGroups              | 1                                                                                                                                                                                                                          |
| ldapOverrideMainServer        |                                                                                                                                                                                                                            |
| ldapPagingSize                | 500                                                                                                                                                                                                                        |
| ldapPort                      | 389                                                                                                                                                                                                                        |
| ldapQuotaAttribute            |                                                                                                                                                                                                                            |
| ldapQuotaDefault              |                                                                                                                                                                                                                            |
| ldapTLS                       | 0                                                                                                                                                                                                                          |
| ldapUserAvatarRule            | default                                                                                                                                                                                                                    |
| ldapUserDisplayName           | cn                                                                                                                                                                                                                         |
| ldapUserDisplayName2          |                                                                                                                                                                                                                            |
| ldapUserFilter                | (&(|(objectclass=person)(objectclass=user))(|(|(memberof=CN=APP_Owncloud,[REDACTED],DC=net)(primaryGroupID=20672))))                                                                                                       |
| ldapUserFilterGroups          | APP_Owncloud                                                                                                                                                                                                               |
| ldapUserFilterMode            | 0                                                                                                                                                                                                                          |
| ldapUserFilterObjectclass     | person;user                                                                                                                                                                                                                |
| ldapUuidGroupAttribute        | auto                                                                                                                                                                                                                       |
| ldapUuidUserAttribute         | auto                                                                                                                                                                                                                       |
| turnOffCertCheck              | 0                                                                                                                                                                                                                          |
| turnOnPasswordChange          | 0                                                                                                                                                                                                                          |
| useMemberOfToDetectMembership | 1                                                                                                                                                                                                                          |
+-------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Client configuration

Browser: Google Chrome 85

Operating system: Windows 10 1909

Logs

Web server error log

Web server error log

Nothing:

[Thu Aug 27 00:00:02.390652 2020] [core:notice] [pid 572] AH00094: Command line: '/usr/sbin/apache2'

Nextcloud log (data/nextcloud.log)

Nextcloud log

See above under Actual behaviour

Browser log

Browser log

See above under Actual behaviour

@Zoddo Zoddo added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Aug 27, 2020
@Zoddo
Copy link
Author

Zoddo commented Aug 28, 2020

Ok, so after further investigation I found the cause of the issue.

First, it's not related at all to LDAP. Some very old local accounts were also affected.

Every affected users had their carddata in oc_cards to something like Resource id #XXX instead of an actual VCF blob.
image

I don't really known when this happened (we mainly use nextcloud to share files with outside users, so we almost never try to share a file with a local user).

I was able to fix it by purging the system address book with the two following SQL queries (system addressbook id is 2 in my case):

DELETE FROM oc_cards_properties WHERE addressbookid = 2;
DELETE FROM oc_cards WHERE addressbookid = 2;

Then regenerating it with:

occ dav:sync-system-addressbook

I will leave this issue open right now, in case someone have an idea of what may have caused this issue.

@szaimen
Copy link
Contributor

szaimen commented Jun 23, 2021

Is this Issue still valid in NC21.0.2? If not, please close this issue. Thanks! :)

@Zoddo
Copy link
Author

Zoddo commented Jun 23, 2021

I can't reproduce, because this one was a one-shot issue.
The "corruption" of VCF data may have happened in a very old version even if we hadn't noticed at that time.

A proper fix that would definitely resolve this issue would be to regenerate the VCF data on the fly when NC detects that it is corrupted (or at least, displaying a warning in the administration and providing a CLI command that fixes it).

It's up to you to decide if this is worth implementing. Feel free to close this issue if it's deemed rare enough.

@szaimen
Copy link
Contributor

szaimen commented Jun 23, 2021

Thanks! I think the demand is rare enough.

@szaimen szaimen closed this as completed Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info
Projects
None yet
Development

No branches or pull requests

2 participants