Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the sharing menu implicitly confirms input fields #25978

Open
danxuliu opened this issue Mar 6, 2021 · 1 comment
Open

Closing the sharing menu implicitly confirms input fields #25978

danxuliu opened this issue Mar 6, 2021 · 1 comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: sharing

Comments

@danxuliu
Copy link
Member

danxuliu commented Mar 6, 2021

I do not know if this is intended or not, but I found it a bit unexpected, so just in case :-)

Steps to reproduce

  • Open the Files app
  • Open the details view for a file
  • Open the sharing tab
  • Create a new link share
  • Open the link share menu
  • Enable "Password protected". This will generate a random password that will be shown.
  • Type a different password, but do not press enter or click the confirm button
  • Close the link share menu by clicking outside it

Expected result

The password was not not explicitly confirmed, so it is not saved.

Actual results

The password was saved even if it was not explicitly confirmed.

Whether the password was saved or not can be checked by opening the link share and entering the expected password.

@danxuliu danxuliu added bug 1. to develop Accepted and waiting to be taken care of feature: sharing labels Mar 6, 2021
@szaimen
Copy link
Contributor

szaimen commented Jan 23, 2023

This sounds more like a feature request and design discussion to me

@szaimen szaimen added enhancement design Design, UI, UX, etc. and removed bug labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: sharing
Projects
None yet
Development

No branches or pull requests

2 participants