after upgrade theme setting is gone

[mcnesium]

After upgrading from 10.0.1 to 10.0.2 theme setting in config.php has been set to 'theme' => '',

(reopened from here)

[MorrisJobke]

cc @LukasReschke @rullzer @karlitschek

[nickvergessen]

Well this is still the intended behaviour. Themes are disabled on updates because we don't know whether they have been adjusted to the new changes yet?

[nickvergessen]

server/lib/base.php

Lines 377 to 378 in 30689f3

	$oldTheme = $systemConfig->getValue('theme');
	$systemConfig->setValue('theme', '');

It also prints the message:

The theme %s has been disabled.

I'm not really sure if we should risk this.

[mcnesium]

I understand your approach. Though, compared to other software, it seems a little strange to me as an administrator, that an nc instance is more or less reset to default after an upgrade. That includes not only the theme, but apps as well. Any non-default app is disabled after an upgrade. I only use calendar, contacts, direct_menu and mail, so I can't tell whether this is true for all non-default apps.

While after using and upgrading oc/nc for years I am used to just occ app:enable foo by now after an upgrade, I was not really aware of themes being reset too, even though there is a note as you state.

So there are two enhancements coming to my mind:

• There should be an occ command to (re-)enable a theme just like an app
• After an upgrade, disabled features should be announced more obvious, both in the browser and on command line. For example a red-backgrounded note "Congratulations, everything went fine, BUT: app 1, app 2, theme X … are still disabled. Re-enable them using occ re-enable everything"

[juliushaertl]

@mcnesium ./occ config:system:set theme --value=MyTheme should work just fine for enabling the theme again. 😉

[nickvergessen]

I think the console is already coloring it good:

But yeah, the web UI needs a bit more clearness on that.

[mcnesium]

This notice scrolls up and is gone, if there is more output. Not unlikely on a production setting. Thats why I proposed to announce it at the end of the upgrade process again.

[DJCrashdummy]

this also appeared after the update of just the calendar-app itself!

less than a week ago calender 1.5.2 was published and i installed it right away. after this the internal/server-update with the original background-image (i don't know how it is called correct) had to be done. everything went smoothly and so i didn't think further about it...
then a user hinted me that there is a other theme present and i had to detect that 'theme' => 'mytheme', had changed to 'theme' => '',!

i understand and fine with it if themes are disabled for safety reasons, but it would be nice to restore the used theme afterwards or at least a hint after the update to manually do so.