Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuning of Theming (color) options #328

Closed
hitam4450 opened this issue Jul 6, 2016 · 7 comments
Closed

Tuning of Theming (color) options #328

hitam4450 opened this issue Jul 6, 2016 · 7 comments
Labels
enhancement feature: theming good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@hitam4450
Copy link

hitam4450 commented Jul 6, 2016

I really appreciate the Theming options in the administrator menu to be able to achieve individual Themes.
Since this is Version 1.0, there might be room for further development.
I would like to see options for

  **Saturation
  Lightness**

as in (http://www.w3schools.com/colors/colors_picker.asp) for further color fine tuning!

Thanks and best regards, hitam4450

@hitam4450 hitam4450 changed the title Feature Request: Tuning of Theming app Feature Request: Tuning of Theming options (app) Jul 6, 2016
@MorrisJobke MorrisJobke added enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in. feature: theming labels Jul 6, 2016
@MariusBluem MariusBluem changed the title Feature Request: Tuning of Theming options (app) Tuning of Theming options (app) Jul 7, 2016
@juliushaertl
Copy link
Member

Is this really something needed? The current color picker allows to select any possible RGB-hex-value.
As far as I can tell, the current color picker http://jscolor.com/ has no support for adding saturation/lightness switches, so adding them would mean a lot of additional code.

@jospoortvliet
Copy link
Member

I agree with @juliushaertl - you can even just insert a hex color so anything is possible already. I think the color selection is fine ;-)

@hitam4450
Copy link
Author

Yes, the color selection is Ok...but not the tuning of the color selection!

I tried several different colors already, all are to bright and not really nice!

regards, hitam4450

@hitam4450 hitam4450 changed the title Tuning of Theming options (app) Tuning of Theming (color) options Jul 9, 2016
@Bugsbane
Copy link
Member

Bugsbane commented Jul 9, 2016

It's already possible to alter saturation and lightness. Alter saturation by raising / lowering the circle, alter lightness by raising/lowering the bar on the right. That said, jscolor does already support entering straight HSV (hue, saturation, value/lightness) values very easily. Just take a look at the "HSV/HVS mode" example script (4 lines) here.

@hitam4450
Copy link
Author

Well, that sounds nice. The feature is not available in NextCloud theming app!

regards, hitam4450

@juliushaertl
Copy link
Member

But changing jscolor to HSV / HVS mode will not add any additional value, any possible color can also be selected with the current color picker.

@jancborchardt
Copy link
Member

Closing this because of aforementioned comments. Any color value is selectable in this color picker. Adding more options will not make it simpler for the majority but more confusing. If you really want to have a specific color, then you can also copy/paste it from the style guide of your organization, or use a full graphics program to adjust the color perfectly. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature: theming good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

6 participants