Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrast for active/hover on the app navigation might be too low #33800

Open
juliushaertl opened this issue Sep 1, 2022 · 3 comments
Open

Contrast for active/hover on the app navigation might be too low #33800

juliushaertl opened this issue Sep 1, 2022 · 3 comments

Comments

@juliushaertl
Copy link
Member

From #33568 (comment)
contrast quite low, might not pass accessibility test:

image

@jancborchardt might be a critical one for accessibility, so maybe you can provide a mockup or spec so this can be picked up.

@jancborchardt
Copy link
Member

How does it look like for focus? As long as we have proper borders there it could be fine.

Also, we could use bold text for the active entry? (Not for hover/focus)

@ya-d
Copy link

ya-d commented Sep 5, 2022

Maybe hover and focus backgrounds should be transparent too, if the entire background is transparent. Looks a bit dull otherwise. Also the perceived color changes quite a lot depended from the color of the background image which is quite irritating. Probably this effect is reduced if hover is transparent too.

Appears almost white:
image

Appears gray against bright background (and very low contrast):
image

@szaimen
Copy link
Contributor

szaimen commented Sep 7, 2022

@jancborchardt how can we solve that?

@szaimen szaimen added the high label Sep 12, 2022
@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants