Theming: aspect ratio of logo

[jospoortvliet]

I added a round image as theme and whadda-you-know - it didn't look so awesome:

I think we should either preserve the aspect ratio (best) or tell users what aspect ratio the logo must have ;-)

Shouldn't be very hard to fix.

[MariusBluem]

• add some information about optimal size (px) for uploaded pictures

[juliushaertl]

There is also an issue on the login page. Images that are too high, get cropped there.

[jospoortvliet]

@juliushaertl ah yes they do...

[Bugsbane]

Personally I'd recommend keeping the aspect ration with max-height and max-width values on both images.

[clorenz150]

In apps/theming/lib/controller/themingcontroller.php at line 223 I replaced the content of #header .logo-icon with:

width: 62px;
height: 34px;
background-image: url(\'./logo?v='.$cacheBusterValue.'\');
background-size: contain;
vertical-align:middle;
display: inline-block;

Looks fine for me, but I'm not sure if this has site affects.

[Bugsbane]

Looks good @clorenz150 👍

[MorrisJobke]

@clorenz150 Could I ask you to open this change as a pull request?

[christianpoortvliet]

Does not seem to work with transparant png's too, so that is a bummer.

[Bugsbane]

Does not seem to work with transparant png's

I imagine this is likely a browser specific issue, although I'd need to check. What browser are you viewing on?

[Bugsbane]

Sorry, hit the wrong button. Didn't mean to close this issue.

[MorrisJobke]

Fixed with #525