Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable usage of svg favicons and remove imagick from iconbuilder #36607

Open
szaimen opened this issue Feb 8, 2023 · 11 comments
Open

Enable usage of svg favicons and remove imagick from iconbuilder #36607

szaimen opened this issue Feb 8, 2023 · 11 comments
Labels

Comments

@szaimen
Copy link
Contributor

szaimen commented Feb 8, 2023

This allows us to get rid of using imagick in iconbuilder of the theming app, which in return allows us to not enforce this requirement anymore since gd and imaginary can be used for all other tasks.

Julius found this: https://www.leereamsnyder.com/blog/favicons-in-2021#safari-does-not-fully-support-svg-icons

cc @juliushaertl

@szaimen szaimen added technical debt 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 8, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Feb 8, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Feb 8, 2023

also cc @nextcloud/ios

@juliushaertl
Copy link
Member

Seems to work just fine with an svg and the mask for safari:

Screenshot 2023-02-08 at 14 10 10

Now we'd need to check if there is a way to invert the svg to be filled with masking out the app icon or if the new safari icon design would be fine, but otherwise I'd say it would be a good step to get rid of imagick there.

@juliushaertl
Copy link
Member

Would also solve #27502

@szaimen
Copy link
Contributor Author

szaimen commented Feb 8, 2023

Great 🎉

@szaimen szaimen changed the title investigate if safari now supports svg favicons Enabke usage of svg favicons and remove imagick from iconbuilder Feb 8, 2023
@szaimen szaimen changed the title Enabke usage of svg favicons and remove imagick from iconbuilder Enable usage of svg favicons and remove imagick from iconbuilder Feb 8, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Feb 8, 2023

Maybe someone with a mac could look into this for 27? :)

I could help testing a PR on other platforms :)

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 8, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Mar 7, 2023

Also cc @AndyScherzinger

@AndyScherzinger
Copy link
Member

I am not having a mac, so If it works for Julius I think we are fine.

@szaimen
Copy link
Contributor Author

szaimen commented May 1, 2023

Also cc @nextcloud/server

@solracsf
Copy link
Member

Any chances to see this landing in v28?

@szaimen
Copy link
Contributor Author

szaimen commented Sep 27, 2023

It was not prioritized so unfortunately no. But cc @sorbaugh and @AndyScherzinger

@AndyScherzinger
Copy link
Member

What @szaimen said. So given our priorities for v28 we won't have the capacity. However if somebody would be willing to contribute an implementation than we are more than happy to review'n'merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants