Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.3.3.2/2.1 - Modal dialog "Online status" - The input field "What is your status" has a label, but it is not available to visually impaired users due to the use of "hidden-visually." (1) #37083

Closed
AndyScherzinger opened this issue Mar 7, 2023 · 9 comments · Fixed by #40043
Assignees
Labels

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 7, 2023

see also #37091

51e36c48b52ba8aa27249843b98fe342

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-9f92015c98-v2-n1

@JuliaKirschenheuter
Copy link
Contributor

Dear @michaelnissenbaum sorry for a stupid question but what is wrong with our hidden-visually class?

Screenshot from 2023-08-15 11-38-23

@michaelnissenbaum
Copy link

Hi @JuliaKirschenheuter. There's nothing wrong with the class. The issue lies elsewhere. It needs to be ensured that the input field has a visual label, and in our case, you are hiding the label element. Please make sure that placeholder attributes are not a substitute for a visual label.
CleanShot 2023-08-16 at 19 55 17@2x

@JuliaKirschenheuter
Copy link
Contributor

Thank you @michaelnissenbaum!
I think design-wise there is no place for visual label. Should i in that case take a placeholder completely away?

@michaelnissenbaum
Copy link

@JuliaKirschenheuter , as I've mentioned before, we need a visual label. We can't do without it. Placeholder attributes are not a substitute for visual labels. In this case, you'll need to adjust the design accordingly or use flyout labels.

@JuliaKirschenheuter
Copy link
Contributor

Hi @jancborchardt
what do you mean could we find a solution here with visible label?

@marcoambrosini
Copy link
Member

@JuliaKirschenheuter we have this coming soon

@susnux
Copy link
Contributor

susnux commented Aug 18, 2023

we have this coming soon

I think this will help fixing a lot of those issues, where a "plain" label does not match and re misuse a placeholder for it instead :)

@JuliaKirschenheuter
Copy link
Contributor

@michaelnissenbaum would you approve such solution? nextcloud-libraries/nextcloud-vue#4394 (comment)

@michaelnissenbaum
Copy link

I will accept the solution, just ensure that the contrasts of labels and graphical user interface elements such as input field borders meet the requirements.

@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of 3. to review Waiting for reviews labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants