Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App store shows group gid instead of displayname when restricting access #37333

Open
5 of 9 tasks
mkrecek234 opened this issue Mar 22, 2023 · 4 comments
Open
5 of 9 tasks
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 26-feedback bug feature: apps management good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@mkrecek234
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Create a user group ˋtestˋ as an admin.
Rename the user group to ˋfoò
Go to NC Apps section and select any active app
Restrict app access to a group

The list of groups selectable are showing the ˋgidˋ unique name, here ˋtestˋ - renaming that group did not change the ˋgidˋ but only ˋdisplaynamè

Expected: The app store group selector should show displayname not gid

Steps to reproduce

See above

Expected behavior

See above

Installation method

Community Web installer on a VPS or web space

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

N/A

List of activated Apps

N/A

Nextcloud Signing status

N/A

Nextcloud Logs

N/A

Additional info

N/A

@mkrecek234 mkrecek234 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Mar 22, 2023
@szaimen
Copy link
Contributor

szaimen commented Mar 22, 2023

Hi, which nc version?

@mkrecek234
Copy link
Author

NC 26

@joshtrichards
Copy link
Member

Predates v26. Reproduced in v25.

@joshtrichards
Copy link
Member

The issue may be here:

return this.app.groups.map(group => { return { id: group, name: group } })

Shouldn't this be something more like:

return this.app.groups

It doesn't seem the map method call serves a purpose here. And even if it does serve one that I'm not seeing, it does not seem like this could possibly being doing what was intended since every group object's id and name elements will both end up being populated with objects that each contain the entire (and same) id and name arrays themselves (!)

@joshtrichards joshtrichards added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. and removed feature: users and groups labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 26-feedback bug feature: apps management good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

3 participants